config: don't serve image blobs with Content-Disposition: inline#1811
Merged
alxndrsn merged 5 commits intoApr 25, 2026
Merged
Conversation
matthew-white
approved these changes
Apr 22, 2026
alxndrsn
commented
Apr 25, 2026
alxndrsn
commented
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #1769, logo and hero-image on the login page are displayed in
<img>tags.Content-Disposition: inlineis a convenience to allow directly-linked images to display in the browser instead of downloading.It's unlikely that login-page branding images would be directly linked.
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
Content-Disposition: inlineis risky with user-submitted content, and should only be used when necessary.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Unlikely to have any effect as it's a new feature, and linking directly to config-blob-images is a surprising use case.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass, or witnessed Github completing all checks with success