Skip to content

config: don't serve image blobs with Content-Disposition: inline #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxndrsn merged 5 commits into from
Apr 25, 2026
Merged

config: don't serve image blobs with Content-Disposition: inline #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60d9788
config: don't serve image blobs with Content-Disposition: inline
Apr 21, 2026
4474ff1
update tests
Apr 21, 2026
8171459
Apply suggestion from @alxndrsn
alxndrsn Apr 25, 2026
ce8e289
Apply suggestion from @alxndrsn
alxndrsn Apr 25, 2026
c276242
Merge branch 'master' into config-blobs-not-content-disposition-inline
alxndrsn Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/resources/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ module.exports = (service, endpoint, anonymousEndpoint) => {

// Configs that store blobs
const blob = await Blobs.getById(config.blobId).then(getOrNotFound);
return blobResponse(s3, key, blob, true);
return blobResponse(s3, key, blob);
Comment thread
alxndrsn marked this conversation as resolved.
Comment thread
alxndrsn marked this conversation as resolved.
};

service.get('/config/public/:key', anonymousEndpoint(async (container, { params }) => {
Expand Down
41 changes: 19 additions & 22 deletions test/integration/api/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,29 +62,26 @@ describe('api: /config', () => {
});
}));

it('should inline select image types', testService(async (service) => {
const asAlice = await service.login('alice');

await asAlice.post('/v1/config/logo')
.set('Content-Type', 'image/jpeg')
.send('testimage')
.expect(200);
await asAlice.get('/v1/config/logo')
.expect(200)
.then(({ headers }) => {
headers['content-disposition'].should.startWith('inline');
});
[
'image/jpeg',
'image/svg+xml',
Comment thread
alxndrsn marked this conversation as resolved.
'text/html',
'text/javascript',
].forEach(mimeType => {
it(`should not set Content-Disposition: inline for mime type: ${mimeType}`, testService(async (service) => {
const asAlice = await service.login('alice');

await asAlice.post('/v1/config/logo')
.set('Content-Type', 'image/svg+xml')
.send('testimage2')
.expect(200);
await asAlice.get('/v1/config/logo')
.expect(200)
.then(({ headers }) => {
headers['content-disposition'].should.startWith('attachment');
});
}));
await asAlice.post('/v1/config/logo')
.set('Content-Type', mimeType)
.send('testimage')
.expect(200);
await asAlice.get('/v1/config/logo')
.expect(200)
.then(({ headers }) => {
headers['content-disposition'].should.startWith('attachment');
});
}));
});
});

it('should overwrite the existing config', testService((service) =>
Expand Down