Skip to content

Update NodeJS version to match prod#1834

Merged
alxndrsn merged 2 commits into
getodk:masterfrom
alxndrsn:fix-node-version
May 23, 2026
Merged

Update NodeJS version to match prod#1834
alxndrsn merged 2 commits into
getodk:masterfrom
alxndrsn:fix-node-version

Conversation

@alxndrsn
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn commented May 21, 2026

Closes getodk/central#1806

What has been done to verify that this works as intended?

  • CI

Why is this the best possible solution? Were any other approaches considered?

Alternative was to include the changes to package-lock.json: running npm i locally removes "peer": true from many dependencies. However, without that change npm ci still seems happy.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No effect.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass, or witnessed Github completing all checks with success
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn marked this pull request as ready for review May 21, 2026 16:39
@matthew-white
Copy link
Copy Markdown
Member

We should probably make a similar change to central-frontend as well. Probably after getodk/central-frontend#1549 gets merged, since that also touches package.json.

@matthew-white
Copy link
Copy Markdown
Member

Alternative was to include the changes to package-lock.json: running npm i locally removes "peer": true from many dependencies.

We'll probably need to commit those changes at some point, but I agree that that can happen in a later PR. Perhaps whenever we update dependencies next.

@alxndrsn alxndrsn merged commit cd20cf8 into getodk:master May 23, 2026
6 checks passed
@alxndrsn alxndrsn deleted the fix-node-version branch May 23, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Node version in dev to match prod

2 participants