Set actor properties when creating public link or app user#1837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to send actor properties in the POST creation request for app users and public links. Previously, you could only set the properties in a follow-up PATCH request.
This is a piece that was missing from #1824
Needed for
What has been done to verify that this works as intended?
Tests, using it.
Why is this the best possible solution? Were any other approaches considered?
The response from the POST create event is the same as before - the properties have not been added to the response. This may be a little awkward, but the POST response is already different from the GET response because it contains the full
sessiondetails, whereas the GET only contains the token from the session.Example public link response from POST
from GET
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Extends API for app user and public link creation to use new actor properties.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Will update docs in followup PR
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass, or witnessed Github completing all checks with success