Allow user to upload entity CSV with missing properties#1551
Open
matthew-white wants to merge 1 commit into
Open
Allow user to upload entity CSV with missing properties#1551matthew-white wants to merge 1 commit into
matthew-white wants to merge 1 commit into
Conversation
matthew-white
commented
May 14, 2026
Member
Author
matthew-white
left a comment
matthew-white
left a comment
There was a problem hiding this comment.
Notes from interactive code review
| <entity-upload-data-error v-if="dataError != null" | ||
| :message="dataError"/> | ||
| </entity-upload-file-select> | ||
| <entity-upload-header-review v-if="headerWarnings != null && headerErrors == null" |
Member
Author
There was a problem hiding this comment.
Suggested change
| <entity-upload-header-review v-if="headerWarnings != null && headerErrors == null" | |
| <entity-upload-header-review v-if="headerWarnings != null" |
| return obj; | ||
| }; | ||
| const { i18n: globalI18n, redAlert } = inject('container'); | ||
| const parseEntities = async (file, headerResults, signal) => { |
Member
Author
There was a problem hiding this comment.
Instead of passing header warnings here as part of headerInfo, let's move all the setting that this function does into selectFile() below. This function could then just return the results of parsing the data. We wouldn't need to distinguish between headerResults and headerInfo.
ktuite
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#1787.
What has been done to verify that this works as intended?
New tests. I also tried it out locally.
Why is this the best possible solution? Were any other approaches considered?
The existing
EntityUploadmodal is pretty complicated, so I tried not to change too much of the existing code. Instead, I added a new ref to store the warning about missing properties (headerWarnings) and a new component to show the warning (EntityUploadHeaderReview). As I continue working on getodk/central#1784, some of this approach may change.Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes