nginx/selfsign: use standard RSA key size#2035
Merged
Merged
Conversation
The previous size of 4086 was likely copied from the README for `marvambass/nginx-ssl-secure` (https://github.com/MarvAmBass/docker-nginx-ssl-secure). This was the original nginx base image used in this repo, introduced in 7cd48f7. There's no obvious benefit to using a non-standard key size, and it's likely to cause confusion, and maybe affect security scoring. For a comparison: * https://www.google.com/search?q=%22openssl+req+-x509+-newkey+rsa%3A4086%22: 10 results * https://www.google.com/search?q=%22openssl+req+-x509+-newkey+rsa%3A4096%22: 275 results
lognaturel
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous size of 4086 was likely copied from the README for
marvambass/nginx-ssl-secure(https://github.com/MarvAmBass/docker-nginx-ssl-secure). This was the original nginx base image used in this repo, introduced in 7cd48f7.Update: per MarvAmBass/docker-nginx-ssl-secure#8,
4086was a typo.There's no obvious benefit to using a non-standard key size, and it's likely to cause confusion, and maybe affect security scoring.
For a comparison:
Closes #2034
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
There's no obvious benefit to using a non-standard key size, and it's likely to cause confusion, and maybe affect security scoring.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Unlikely to have an effect - new self-signing self-hosters shouldn't notice, existing users shouldn't have a new key generated.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)