Update mssql_odbc.py schema query to use QUOTENAME#7642
Open
gauiPPP wants to merge 1 commit into
Open
Conversation
QUOTENAME will add [] around the values and this will lead to correctly handling database names, schema names and table names with spaces and other SQL syntax problematic characters.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
Same comment is applied for this PR, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUOTENAME will add [] around the values and this will lead to correctly handling database names, schema names and table names with spaces and other SQL syntax problematic characters.
What type of PR is this?
Description
How is this tested?
SQL query in MS SQL 2022 server with previous and new query
Related Tickets & Documents
Other pull about mssql.py about the same thing.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)