Skip to content

Commit ffffd9b

Browse files
cameroncookecodex
andcommitted
fix(build): Add smoke app version metadata
Generated Info.plists need a valid CFBundleVersion for simulator installation on Xcode 15.4. Add standard Xcode version build settings to the generated binary smoke app and test bundle. Refs EME-1168 Co-Authored-By: Codex <noreply@openai.com>
1 parent 3810a60 commit ffffd9b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

scripts/smoke_binary_integration_ios.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,11 @@ def project_settings
166166
end
167167

168168
def app_settings
169-
project_settings.merge("GENERATE_INFOPLIST_FILE" => "YES", "INFOPLIST_KEY_UILaunchScreen_Generation" => "YES", "LD_RUNPATH_SEARCH_PATHS" => ["$(inherited)", "@executable_path/Frameworks"], "PRODUCT_BUNDLE_IDENTIFIER" => "com.emergetools.SnapshotPreviews.BinarySmoke", "PRODUCT_NAME" => "$(TARGET_NAME)", "SWIFT_EMIT_LOC_STRINGS" => "NO", "TARGETED_DEVICE_FAMILY" => "1")
169+
project_settings.merge("CURRENT_PROJECT_VERSION" => "1", "GENERATE_INFOPLIST_FILE" => "YES", "INFOPLIST_KEY_UILaunchScreen_Generation" => "YES", "LD_RUNPATH_SEARCH_PATHS" => ["$(inherited)", "@executable_path/Frameworks"], "MARKETING_VERSION" => "1.0", "PRODUCT_BUNDLE_IDENTIFIER" => "com.emergetools.SnapshotPreviews.BinarySmoke", "PRODUCT_NAME" => "$(TARGET_NAME)", "SWIFT_EMIT_LOC_STRINGS" => "NO", "TARGETED_DEVICE_FAMILY" => "1")
170170
end
171171

172172
def test_settings
173-
project_settings.merge("BUNDLE_LOADER" => "$(TEST_HOST)", "ENABLE_TESTING_SEARCH_PATHS" => "YES", "GENERATE_INFOPLIST_FILE" => "YES", "LD_RUNPATH_SEARCH_PATHS" => ["$(inherited)", "@executable_path/Frameworks", "@loader_path/Frameworks"], "PRODUCT_BUNDLE_IDENTIFIER" => "com.emergetools.SnapshotPreviews.BinarySmokeTests", "PRODUCT_NAME" => "$(TARGET_NAME)", "SWIFT_EMIT_LOC_STRINGS" => "NO", "TARGETED_DEVICE_FAMILY" => "1", "TEST_HOST" => "$(BUILT_PRODUCTS_DIR)/#{APP_TARGET}.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/#{APP_TARGET}")
173+
project_settings.merge("BUNDLE_LOADER" => "$(TEST_HOST)", "CURRENT_PROJECT_VERSION" => "1", "ENABLE_TESTING_SEARCH_PATHS" => "YES", "GENERATE_INFOPLIST_FILE" => "YES", "LD_RUNPATH_SEARCH_PATHS" => ["$(inherited)", "@executable_path/Frameworks", "@loader_path/Frameworks"], "MARKETING_VERSION" => "1.0", "PRODUCT_BUNDLE_IDENTIFIER" => "com.emergetools.SnapshotPreviews.BinarySmokeTests", "PRODUCT_NAME" => "$(TARGET_NAME)", "SWIFT_EMIT_LOC_STRINGS" => "NO", "TARGETED_DEVICE_FAMILY" => "1", "TEST_HOST" => "$(BUILT_PRODUCTS_DIR)/#{APP_TARGET}.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/#{APP_TARGET}")
174174
end
175175

176176
def render_project

0 commit comments

Comments
 (0)