Code Quality: PR #435 #1442
cameroncookecodeql
on: dynamic
Matrix: analyze
Annotations
1 error and 2 warnings
|
`simulator-management keyboard-shortcut` is not a valid CLI command:
CHANGELOG.md#L7
The changelog references `simulator-management keyboard-shortcut` as if it is a real CLI tool, but no such tool exists in the manifests. The tools that use the keyboard-shortcut helper internally are `simulator-management toggle-software-keyboard` and `simulator-management toggle-connect-hardware-keyboard`; a user or agent following this guidance would run an invalid command.
|
|
Changelog references non-existent tool `simulator-management keyboard-shortcut`:
CHANGELOG.md#L7
The changelog entry names `simulator-management keyboard-shortcut` as a tool, but no such public tool or CLI command exists; the actual public tools that send keyboard shortcuts are `toggle_software_keyboard` / `toggle-software-keyboard` and `toggle_connect_hardware_keyboard` / `toggle-connect-hardware-keyboard`.
|
|
Normalizer hardcodes fixture-specific location to force stable snapshot suite name:
src/snapshot-tests/__tests__/json-normalize.test.ts#L104
The `normalizeDiagnosticTestFailure` function matches on the exact fixture coordinates `'CalculatorServiceTests.swift:37'` to replace any `suite` value with `<SWIFT_TEST_SUITE>`, which is fixture-pinned normalization rather than a general strategy — it forces snapshot stability by special-casing a specific test case regardless of what the actual suite value is.
|