fix(benchmarks): Isolate local suite discovery tests

Allow Claude UI suite discovery helpers to receive suite directories so
tests can exercise local suite lookup without writing fake files into
the real repository tree.

Co-Authored-By: Codex <noreply@openai.com>

Author: cameroncooke

src/benchmarks/claude-ui/__tests__/claude-ui-benchmark.test.ts

@@ -89,16 +89,22 @@ describe('Claude UI benchmark harness', () => {
   });
 
   it('discovers local private suites when present', async () => {
-    const localSuitesDir = path.join(repoRoot, 'benchmarks/claude-ui/local/suites');
-    const suiteName = `unit-private-suite-${process.pid}`;
-    const suitePath = path.join(localSuitesDir, `${suiteName}.yml`);
-    await mkdir(localSuitesDir, { recursive: true });
-    await writeFile(suitePath, `name: ${suiteName}\nprompt: ../prompts/weather.md\n`, 'utf8');
+    const dir = await mkdtemp(path.join(tmpdir(), 'claude-ui-suites-'));
     try {
-      await expect(resolveSuitePath(suiteName)).resolves.toBe(suitePath);
-      await expect(listSuitePaths()).resolves.toContain(suitePath);
+      const suiteDirectories = {
+        suitesDir: path.join(dir, 'suites'),
+        localSuitesDir: path.join(dir, 'local-suites'),
+      };
+      const suiteName = `unit-private-suite-${process.pid}`;
+      const suitePath = path.join(suiteDirectories.localSuitesDir, `${suiteName}.yml`);
+      await mkdir(suiteDirectories.suitesDir, { recursive: true });
+      await mkdir(suiteDirectories.localSuitesDir, { recursive: true });
+      await writeFile(suitePath, `name: ${suiteName}\nprompt: ../prompts/weather.md\n`, 'utf8');
+
+      await expect(resolveSuitePath(suiteName, suiteDirectories)).resolves.toBe(suitePath);
+      await expect(listSuitePaths(suiteDirectories)).resolves.toContain(suitePath);
     } finally {
-      await rm(suitePath, { force: true });
+      await rm(dir, { recursive: true, force: true });
     }
   });
 });

src/benchmarks/claude-ui/harness.ts

@@ -58,6 +58,10 @@ interface StreamJsonResult {
   type?: unknown;
   is_error?: unknown;
 }
+interface SuiteDirectories {
+  suitesDir: string;
+  localSuitesDir: string;
+}
 async function fileExists(filePath: string): Promise<boolean> {
   try {
     await access(filePath);
@@ -67,7 +71,10 @@ async function fileExists(filePath: string): Promise<boolean> {
   }
 }
 
-export async function resolveSuitePath(suite: string): Promise<string> {
+export async function resolveSuitePath(
+  suite: string,
+  directories: SuiteDirectories = { suitesDir, localSuitesDir },
+): Promise<string> {
   if (
     path.isAbsolute(suite) ||
     suite.includes(path.sep) ||
@@ -78,8 +85,8 @@ export async function resolveSuitePath(suite: string): Promise<string> {
   }
 
   const candidates = [
-    path.join(suitesDir, `${suite}.yml`),
-    path.join(localSuitesDir, `${suite}.yml`),
+    path.join(directories.suitesDir, `${suite}.yml`),
+    path.join(directories.localSuitesDir, `${suite}.yml`),
   ];
   const matches = [];
   for (const candidate of candidates) {
@@ -110,10 +117,12 @@ async function listYamlFiles(directory: string, required: boolean): Promise<stri
     .sort();
 }
 
-export async function listSuitePaths(): Promise<string[]> {
+export async function listSuitePaths(
+  directories: SuiteDirectories = { suitesDir, localSuitesDir },
+): Promise<string[]> {
   return [
-    ...(await listYamlFiles(suitesDir, true)),
-    ...(await listYamlFiles(localSuitesDir, false)),
+    ...(await listYamlFiles(directories.suitesDir, true)),
+    ...(await listYamlFiles(directories.localSuitesDir, false)),
   ];
 }