fix(cli): Allow hyphens in semver identifiers and check brew exit code

Fix parseVersion regex to accept hyphens in prerelease and build-metadata
identifiers as required by SemVer 2.0.0, so versions like 1.0.0-alpha-1
or 1.0.0-rc-1+build-hash no longer fail to parse.

Check the exit code of `brew info` before attempting to parse its stdout.
Homebrew exits 0 for missing formulas (a quirk the existing empty-formulae
path handles), but other failure modes like a broken brew install or
permission errors exit non-zero with empty stdout — those now surface a
specific exit-code error instead of a misleading "invalid JSON output".

Reported in PR review by Cursor Bugbot and Sentry.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: cameroncooke

src/cli/commands/__tests__/upgrade.test.ts

@@ -202,6 +202,24 @@ describe('upgrade command', () => {
       });
     });
 
+    it('parses prerelease with hyphenated identifier', () => {
+      expect(parseVersion('1.0.0-alpha-1')).toEqual({
+        major: 1,
+        minor: 0,
+        patch: 0,
+        prerelease: 'alpha-1',
+      });
+    });
+
+    it('parses hyphenated prerelease with hyphenated build metadata', () => {
+      expect(parseVersion('1.0.0-rc-1+build-hash')).toEqual({
+        major: 1,
+        minor: 0,
+        patch: 0,
+        prerelease: 'rc-1',
+      });
+    });
+
     it.each([['not-a-version'], ['1.2'], [''], ['1.2.3.4'], ['abc.def.ghi']])(
       'returns undefined for malformed input %j',
       (input) => {
@@ -941,6 +959,19 @@ describe('upgrade command', () => {
         expect(collectStderr(stderrSpy)).toContain('invalid JSON');
       });
 
+      it('homebrew: exits 1 when brew info exits non-zero', async () => {
+        const deps = channelDeps(homebrewMethod(), {
+          stdout: '',
+          stderr: 'Error: Permission denied',
+          exitCode: 1,
+        });
+
+        const code = await runUpgradeCommand({ check: false, yes: false }, deps);
+        expect(code).toBe(1);
+        expect(collectStderr(stderrSpy)).toContain('Homebrew');
+        expect(collectStderr(stderrSpy)).toContain('exited with code 1');
+      });
+
       it('npm-global: exits 1 when npm view exits non-zero', async () => {
         const deps = channelDeps(npmGlobalMethod(), {
           stdout: '',

src/cli/commands/upgrade.ts

@@ -69,7 +69,7 @@ export interface UpgradeOptions {
 
 export function parseVersion(raw: string): ParsedVersion | undefined {
   const stripped = raw.startsWith('v') ? raw.slice(1) : raw;
-  const match = stripped.match(/^(\d+)\.(\d+)\.(\d+)(?:-([a-zA-Z0-9.]+))?(?:\+[a-zA-Z0-9.]+)?$/);
+  const match = stripped.match(/^(\d+)\.(\d+)\.(\d+)(?:-([a-zA-Z0-9.-]+))?(?:\+[a-zA-Z0-9.-]+)?$/);
   if (!match) return undefined;
   return {
     major: Number(match[1]),
@@ -258,6 +258,12 @@ async function fetchLatestVersionFromHomebrew(
     throw new Error(`couldn't determine latest version from Homebrew: ${reason}`);
   }
 
+  if (result.exitCode !== 0) {
+    throw new Error(
+      `couldn't determine latest version from Homebrew: command exited with code ${result.exitCode}`,
+    );
+  }
+
   let data: unknown;
   try {
     data = JSON.parse(result.stdout);