Skip to content

Commit 6716c5b

Browse files
committed
fix: use reconciledFailedTests in passed test calculation
reconciledPassedTests was subtracting the raw failedTests counter instead of reconciledFailedTests, inflating the passed count when individual test failures outnumber the aggregate counter.
1 parent 82972b9 commit 6716c5b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/utils/__tests__/xcodebuild-run-state.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,8 +328,8 @@ describe('xcodebuild-run-state', () => {
328328

329329
expect(summary).toBeDefined();
330330
if (summary?.type === 'summary') {
331-
expect(summary.totalTests).toBe(7);
332-
expect(summary.passedTests).toBe(5);
331+
expect(summary.totalTests).toBe(6);
332+
expect(summary.passedTests).toBe(4);
333333
expect(summary.failedTests).toBe(2);
334334
expect(summary.skippedTests).toBe(0);
335335
}

src/utils/xcodebuild-run-state.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export function createXcodebuildRunState(options: RunStateOptions): XcodebuildRu
199199
const reconciledFailedTests = Math.max(state.failedTests, state.testFailures.length);
200200
const reconciledPassedTests = Math.max(
201201
0,
202-
state.completedTests - state.failedTests - state.skippedTests,
202+
state.completedTests - reconciledFailedTests - state.skippedTests,
203203
);
204204
const reconciledTotalTests =
205205
operation === 'TEST'

0 commit comments

Comments
 (0)