Skip to content

Commit 720b440

Browse files
committed
Remove unused sessionKeys
1 parent ca8dd8a commit 720b440

4 files changed

Lines changed: 2 additions & 8 deletions

File tree

docs/session_management_plan.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,9 @@ export function createSessionAwareTool<TParams>(opts: {
9090
internalSchema: z.ZodType<TParams>;
9191
logicFunction: (params: TParams, executor: CommandExecutor) => Promise<ToolResponse>;
9292
getExecutor: () => CommandExecutor;
93-
// Optional extras to improve UX and ergonomics
94-
sessionKeys?: (keyof SessionDefaults)[];
9593
requirements?: SessionRequirement[]; // preflight, friendlier than raw zod errors
9694
}) {
97-
const { internalSchema, logicFunction, getExecutor, sessionKeys = [], requirements = [] } = opts;
95+
const { internalSchema, logicFunction, getExecutor, requirements = [] } = opts;
9896

9997
return async (rawArgs: Record<string, unknown>): Promise<ToolResponse> => {
10098
try {
@@ -191,7 +189,6 @@ export default {
191189
internalSchema: buildSimulatorSchema,
192190
logicFunction: build_simLogic,
193191
getExecutor: getDefaultCommandExecutor,
194-
sessionKeys: sessionManaged,
195192
requirements: [
196193
{ allOf: ['scheme'], message: 'scheme is required' },
197194
{ oneOf: ['projectPath', 'workspacePath'], message: 'Provide a project or workspace' },
@@ -482,4 +479,4 @@ Notes:
482479

483480
## Next Steps
484481

485-
Would you like me to proceed with Phase 1–3 implementation (store + session tools + middleware), then migrate a first tool (build_sim) and run the test suite?
482+
Would you like me to proceed with Phase 1–3 implementation (store + session tools + middleware), then migrate a first tool (build_sim) and run the test suite?

src/mcp/tools/simulator/launch_app_sim.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ export default {
205205
internalSchema: launchAppSimSchema as unknown as z.ZodType<LaunchAppSimParams>,
206206
logicFunction: launch_app_simLogic,
207207
getExecutor: getDefaultCommandExecutor,
208-
sessionKeys: ['simulatorId', 'simulatorName'],
209208
requirements: [
210209
{ oneOf: ['simulatorId', 'simulatorName'], message: 'Provide simulatorId or simulatorName' },
211210
],

src/mcp/tools/simulator/stop_app_sim.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ export default {
159159
internalSchema: stopAppSimSchema as unknown as z.ZodType<StopAppSimParams>,
160160
logicFunction: stop_app_simLogic,
161161
getExecutor: getDefaultCommandExecutor,
162-
sessionKeys: ['simulatorId', 'simulatorName'],
163162
requirements: [
164163
{ oneOf: ['simulatorId', 'simulatorName'], message: 'Provide simulatorId or simulatorName' },
165164
],

src/utils/typed-tool-factory.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ export function createSessionAwareTool<TParams>(opts: {
7575
internalSchema: z.ZodType<TParams>;
7676
logicFunction: (params: TParams, executor: CommandExecutor) => Promise<ToolResponse>;
7777
getExecutor: () => CommandExecutor;
78-
sessionKeys?: (keyof SessionDefaults)[];
7978
requirements?: SessionRequirement[];
8079
exclusivePairs?: (keyof SessionDefaults)[][]; // when args provide one side, drop conflicting session-default side(s)
8180
}) {

0 commit comments

Comments
 (0)