fix(simulator): restrict PID parsing to colon pattern on first line

resolveAppPid scanned all output lines with a bracket regex that matched
3+ digit numbers like [404], causing HTTP status codes to be returned as
PIDs. Restrict to checking only the first non-empty line using the colon
format (e.g. com.example.app: 42567), which is the actual simctl output
pattern.

Author: cameroncooke

src/utils/__tests__/simulator-steps-pid.test.ts

@@ -7,9 +7,9 @@ import { launchSimulatorAppWithLogging } from '../simulator-steps.ts';
 function createMockChild(exitCode: number | null = null): ChildProcess {
   const emitter = new EventEmitter();
   const child = emitter as unknown as ChildProcess;
-  child.exitCode = exitCode;
+  Object.defineProperty(child, 'exitCode', { value: exitCode, writable: true });
   child.unref = vi.fn();
-  child.pid = 99999;
+  Object.defineProperty(child, 'pid', { value: 99999, writable: true });
   return child;
 }
 

src/utils/simulator-steps.ts

@@ -220,12 +220,9 @@ async function resolveAppPid(logFilePath: string): Promise<number | undefined> {
   while (Date.now() - start < PID_POLL_TIMEOUT_MS) {
     const content = readLogFileSafe(logFilePath);
     if (content) {
-      for (const line of content.split('\n')) {
-        const bracketMatch = line.match(/\[(\d{3,})\]/);
-        if (bracketMatch) {
-          return parseInt(bracketMatch[1], 10);
-        }
-        const colonMatch = line.match(/:\s*(\d+)\s*$/);
+      const firstLine = content.split('\n').find((l) => l.trim().length > 0);
+      if (firstLine) {
+        const colonMatch = firstLine.match(/:\s*(\d+)\s*$/);
         if (colonMatch) {
           return parseInt(colonMatch[1], 10);
         }