fix: Prevent shell injection in build workflow#319
Merged
Conversation
Use environment variables to safely handle github context data in run steps to prevent potential code injection attacks. Fixes https://linear.app/getsentry/issue/VULN-1601 Fixes https://linear.app/getsentry/issue/ENG-7567 Co-Authored-By: fix-it-felix-sentry[bot] <260785270+fix-it-felix-sentry[bot]@users.noreply.github.com>
andreiborza
approved these changes
Apr 30, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c01ef49. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a security vulnerability where
githubcontext data was being directly interpolated in arun:step, which could allow an attacker to inject their own code into the runner.Changes
.github/workflows/build.ymlto use intermediate environment variables (GITHUB_REFandGITHUB_EVENT_NAME) instead of direct interpolation ofgithub.refandgithub.event_nameSecurity Impact
This change mitigates a potential shell injection vulnerability by ensuring that github context data is treated as untrusted input and properly sanitized through environment variables.
References