restructure

Author: betegon

sry/.cursor/hooks.json

@@ -7,4 +7,4 @@
       }
     ]
   }
-}
+}

sry/README.md

@@ -61,12 +61,6 @@ sry api /issues/123/ --method PUT --field status=resolved
 sry api /organizations/ --include                    # Show headers
 ```
 
-### DSN Detection
-
-```bash
-sry dsn detect       # Find Sentry DSN in current project
-```
-
 ## Build
 
 ```bash

sry/src/app.ts

@@ -1,32 +1,30 @@
 import { buildApplication, buildRouteMap } from "@stricli/core";
 import { apiCommand } from "./commands/api.js";
 import { authRoute } from "./commands/auth/index.js";
-import { dsnRoute } from "./commands/dsn/index.js";
 import { issueRoute } from "./commands/issue/index.js";
 import { orgRoute } from "./commands/org/index.js";
 import { projectRoute } from "./commands/project/index.js";
 
 const routes = buildRouteMap({
-  routes: {
-    auth: authRoute,
-    org: orgRoute,
-    project: projectRoute,
-    issue: issueRoute,
-    api: apiCommand,
-    dsn: dsnRoute,
-  },
-  docs: {
-    brief: "A gh-like CLI for Sentry",
-    fullDescription:
-      "sry is a command-line interface for interacting with Sentry. " +
-      "It provides commands for authentication, viewing issues, and making API calls.",
-    hideRoute: {},
-  },
+	routes: {
+		auth: authRoute,
+		org: orgRoute,
+		project: projectRoute,
+		issue: issueRoute,
+		api: apiCommand,
+	},
+	docs: {
+		brief: "A gh-like CLI for Sentry",
+		fullDescription:
+			"sry is a command-line interface for interacting with Sentry. " +
+			"It provides commands for authentication, viewing issues, and making API calls.",
+		hideRoute: {},
+	},
 });
 
 export const app = buildApplication(routes, {
-  name: "sry",
-  versionInfo: {
-    currentVersion: "0.1.0",
-  },
+	name: "sry",
+	versionInfo: {
+		currentVersion: "0.1.0",
+	},
 });

sry/src/commands/api.ts

@@ -1,15 +1,82 @@
+/**
+ * sry api
+ *
+ * Make raw authenticated API requests to Sentry.
+ * Similar to 'gh api' for GitHub.
+ */
+
 import { buildCommand } from "@stricli/core";
 import type { SryContext } from "../context.js";
 import { rawApiRequest } from "../lib/api-client.js";
 
+type HttpMethod = "GET" | "POST" | "PUT" | "DELETE" | "PATCH";
+
 type ApiFlags = {
-  readonly method: "GET" | "POST" | "PUT" | "DELETE" | "PATCH";
+  readonly method: HttpMethod;
   readonly field: string[];
   readonly header: string[];
   readonly include: boolean;
   readonly silent: boolean;
 };
 
+// ─────────────────────────────────────────────────────────────────────────────
+// Request Parsing
+// ─────────────────────────────────────────────────────────────────────────────
+
+const VALID_METHODS: HttpMethod[] = ["GET", "POST", "PUT", "DELETE", "PATCH"];
+
+/**
+ * Parse HTTP method from string
+ */
+function parseMethod(value: string): HttpMethod {
+  const upper = value.toUpperCase();
+  if (!VALID_METHODS.includes(upper as HttpMethod)) {
+    throw new Error(
+      `Invalid method: ${value}. Must be one of: ${VALID_METHODS.join(", ")}`
+    );
+  }
+  return upper as HttpMethod;
+}
+
+/**
+ * Parse a single key=value field into nested object structure
+ */
+function parseFieldValue(value: string): unknown {
+  try {
+    return JSON.parse(value);
+  } catch {
+    return value;
+  }
+}
+
+/**
+ * Set a nested value in an object using dot notation key
+ */
+function setNestedValue(
+  obj: Record<string, unknown>,
+  key: string,
+  value: unknown
+): void {
+  const keys = key.split(".");
+  let current = obj;
+
+  for (let i = 0; i < keys.length - 1; i++) {
+    const k = keys[i];
+    if (!(k in current)) {
+      current[k] = {};
+    }
+    current = current[k] as Record<string, unknown>;
+  }
+
+  const lastKey = keys.at(-1);
+  if (lastKey) {
+    current[lastKey] = value;
+  }
+}
+
+/**
+ * Parse field arguments into request body object
+ */
 function parseFields(fields: string[]): Record<string, unknown> {
   const result: Record<string, unknown> = {};
 
@@ -20,31 +87,18 @@ function parseFields(fields: string[]): Record<string, unknown> {
     }
 
     const key = field.substring(0, eqIndex);
-    let value: unknown = field.substring(eqIndex + 1);
+    const rawValue = field.substring(eqIndex + 1);
+    const value = parseFieldValue(rawValue);
 
-    // Try to parse as JSON for complex values
-    try {
-      value = JSON.parse(value as string);
-    } catch {
-      // Keep as string if not valid JSON
-    }
-
-    // Handle nested keys like "data.name"
-    const keys = key.split(".");
-    let current = result;
-    for (let i = 0; i < keys.length - 1; i++) {
-      const k = keys[i];
-      if (!(k in current)) {
-        current[k] = {};
-      }
-      current = current[k] as Record<string, unknown>;
-    }
-    current[keys.at(-1)] = value;
+    setNestedValue(result, key, value);
   }
 
   return result;
 }
 
+/**
+ * Parse header arguments into headers object
+ */
 function parseHeaders(headers: string[]): Record<string, string> {
   const result: Record<string, string> = {};
 
@@ -62,6 +116,44 @@ function parseHeaders(headers: string[]): Record<string, string> {
   return result;
 }
 
+// ─────────────────────────────────────────────────────────────────────────────
+// Response Output
+// ─────────────────────────────────────────────────────────────────────────────
+
+/**
+ * Write response headers to stdout
+ */
+function writeResponseHeaders(
+  stdout: NodeJS.WriteStream,
+  status: number,
+  headers: Headers
+): void {
+  stdout.write(`HTTP ${status}\n`);
+  headers.forEach((value, key) => {
+    stdout.write(`${key}: ${value}\n`);
+  });
+  stdout.write("\n");
+}
+
+/**
+ * Write response body to stdout
+ */
+function writeResponseBody(stdout: NodeJS.WriteStream, body: unknown): void {
+  if (body === null || body === undefined) {
+    return;
+  }
+
+  if (typeof body === "object") {
+    stdout.write(`${JSON.stringify(body, null, 2)}\n`);
+  } else {
+    stdout.write(`${String(body)}\n`);
+  }
+}
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Command Definition
+// ─────────────────────────────────────────────────────────────────────────────
+
 export const apiCommand = buildCommand({
   docs: {
     brief: "Make an authenticated API request",
@@ -87,16 +179,7 @@ export const apiCommand = buildCommand({
     flags: {
       method: {
         kind: "parsed",
-        parse: (value: string) => {
-          const valid = ["GET", "POST", "PUT", "DELETE", "PATCH"];
-          const upper = value.toUpperCase();
-          if (!valid.includes(upper)) {
-            throw new Error(
-              `Invalid method: ${value}. Must be one of: ${valid.join(", ")}`
-            );
-          }
-          return upper as "GET" | "POST" | "PUT" | "DELETE" | "PATCH";
-        },
+        parse: parseMethod,
         brief: "HTTP method (GET, POST, PUT, DELETE, PATCH)",
         default: "GET" as const,
         variableName: "X",
@@ -133,60 +216,43 @@ export const apiCommand = buildCommand({
     endpoint: string
   ): Promise<void> {
     const { process } = this;
+    const { stdout, stderr } = process;
 
     try {
-      // Parse request body from fields
       const body =
-        flags.field && flags.field.length > 0
-          ? parseFields(flags.field)
-          : undefined;
-
-      // Parse additional headers
+        flags.field?.length > 0 ? parseFields(flags.field) : undefined;
       const headers =
-        flags.header && flags.header.length > 0
-          ? parseHeaders(flags.header)
-          : undefined;
+        flags.header?.length > 0 ? parseHeaders(flags.header) : undefined;
 
-      // Make the request
       const response = await rawApiRequest(endpoint, {
         method: flags.method,
         body,
         headers,
       });
 
-      // Silent mode - just set exit code
+      // Silent mode - only set exit code
       if (flags.silent) {
         if (response.status >= 400) {
           process.exitCode = 1;
         }
         return;
       }
 
-      // Include headers in output
+      // Output headers if requested
       if (flags.include) {
-        process.stdout.write(`HTTP ${response.status}\n`);
-        response.headers.forEach((value, key) => {
-          process.stdout.write(`${key}: ${value}\n`);
-        });
-        process.stdout.write("\n");
+        writeResponseHeaders(stdout, response.status, response.headers);
       }
 
       // Output body
-      if (response.body !== null && response.body !== undefined) {
-        if (typeof response.body === "object") {
-          process.stdout.write(`${JSON.stringify(response.body, null, 2)}\n`);
-        } else {
-          process.stdout.write(`${String(response.body)}\n`);
-        }
-      }
+      writeResponseBody(stdout, response.body);
 
       // Set exit code for error responses
       if (response.status >= 400) {
         process.exitCode = 1;
       }
     } catch (error) {
       const message = error instanceof Error ? error.message : String(error);
-      process.stderr.write(`Error: ${message}\n`);
+      stderr.write(`Error: ${message}\n`);
       process.exitCode = 1;
     }
   },

sry/src/commands/auth/logout.ts

@@ -1,27 +1,33 @@
+/**
+ * sry auth logout
+ *
+ * Clear stored authentication credentials.
+ */
+
 import { buildCommand } from "@stricli/core";
 import type { SryContext } from "../../context.js";
 import { clearAuth, getConfigPath, isAuthenticated } from "../../lib/config.js";
 
 export const logoutCommand = buildCommand({
   docs: {
-    brief: "Log out from Sentry",
+    brief: "Log out of Sentry",
     fullDescription:
-      "Remove stored authentication credentials. " +
-      "After logging out, you will need to run 'sry auth login' to authenticate again.",
+      "Remove stored authentication credentials from the configuration file.",
   },
   parameters: {
     flags: {},
   },
-  async func(this: SryContext): Promise<void> {
+  func(this: SryContext): void {
     const { process } = this;
+    const { stdout } = process;
 
     if (!isAuthenticated()) {
-      process.stdout.write("You are not currently authenticated.\n");
+      stdout.write("Not currently authenticated.\n");
       return;
     }
 
     clearAuth();
-    process.stdout.write("✓ Logged out successfully\n");
-    process.stdout.write(`  Credentials removed from: ${getConfigPath()}\n`);
+    stdout.write("✓ Logged out successfully.\n");
+    stdout.write(`  Credentials removed from: ${getConfigPath()}\n`);
   },
 });