refactor: extract shared SortDirection and parseSort to arg-parsing

Moves the duplicated SortDirection type, VALID_SORT_DIRECTIONS constant,
and parseSort function from log/list.ts and trace/logs.ts into the
shared arg-parsing module.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sergical

src/commands/log/list.ts

@@ -10,7 +10,11 @@
 import * as Sentry from "@sentry/node-core/light";
 import type { SentryContext } from "../../context.js";
 import { listLogs, listTraceLogs } from "../../lib/api-client.js";
-import { validateLimit } from "../../lib/arg-parsing.js";
+import {
+  parseSort,
+  type SortDirection,
+  validateLimit,
+} from "../../lib/arg-parsing.js";
 import { AuthError, stringifyUnknown } from "../../lib/errors.js";
 import {
   buildLogRowCells,
@@ -41,9 +45,6 @@ import {
 } from "../../lib/trace-target.js";
 import { getUpdateNotification } from "../../lib/version-check.js";
 
-/** Sort direction for log output */
-type SortDirection = "newest" | "oldest";
-
 type ListFlags = {
   readonly limit: number;
   readonly query?: string;
@@ -101,20 +102,6 @@ function parseLimit(value: string): number {
   return validateLimit(value, MIN_LIMIT, MAX_LIMIT);
 }
 
-/** Valid sort direction values */
-const VALID_SORT_DIRECTIONS: readonly SortDirection[] = ["newest", "oldest"];
-
-/**
- * Parse --sort flag value.
- * @throws Error if value is not "newest" or "oldest"
- */
-function parseSort(value: string): SortDirection {
-  if (!VALID_SORT_DIRECTIONS.includes(value as SortDirection)) {
-    throw new Error(`--sort must be "newest" or "oldest", got "${value}"`);
-  }
-  return value as SortDirection;
-}
-
 /**
  * Parse --follow flag value.
  * Supports: -f (empty string → default interval), -f 10 (explicit interval)

src/commands/trace/logs.ts

@@ -6,7 +6,11 @@
 
 import type { SentryContext } from "../../context.js";
 import { listTraceLogs } from "../../lib/api-client.js";
-import { validateLimit } from "../../lib/arg-parsing.js";
+import {
+  parseSort,
+  type SortDirection,
+  validateLimit,
+} from "../../lib/arg-parsing.js";
 import { openInBrowser } from "../../lib/browser.js";
 import { buildCommand } from "../../lib/command.js";
 import { filterFields } from "../../lib/formatters/json.js";
@@ -25,9 +29,6 @@ import {
   warnIfNormalized,
 } from "../../lib/trace-target.js";
 
-/** Sort direction for log output */
-type SortDirection = "newest" | "oldest";
-
 type LogsFlags = {
   readonly json: boolean;
   readonly web: boolean;
@@ -91,20 +92,6 @@ function parseLimit(value: string): number {
   return validateLimit(value, 1, MAX_LIMIT);
 }
 
-/** Valid sort direction values */
-const VALID_SORT_DIRECTIONS: readonly SortDirection[] = ["newest", "oldest"];
-
-/**
- * Parse --sort flag value.
- * @throws Error if value is not "newest" or "oldest"
- */
-function parseSort(value: string): SortDirection {
-  if (!VALID_SORT_DIRECTIONS.includes(value as SortDirection)) {
-    throw new Error(`--sort must be "newest" or "oldest", got "${value}"`);
-  }
-  return value as SortDirection;
-}
-
 export const logsCommand = buildCommand({
   docs: {
     brief: "View logs associated with a trace",

src/lib/arg-parsing.ts

@@ -261,6 +261,26 @@ export function validateLimit(value: string, min = 1, max = 1000): number {
   return num;
 }
 
+// ---------------------------------------------------------------------------
+// Sort direction parsing (shared by log list, trace logs)
+// ---------------------------------------------------------------------------
+
+/** Sort direction for log output */
+export type SortDirection = "newest" | "oldest";
+
+const VALID_SORT_DIRECTIONS: readonly SortDirection[] = ["newest", "oldest"];
+
+/**
+ * Parse --sort flag value.
+ * @throws Error if value is not "newest" or "oldest"
+ */
+export function parseSort(value: string): SortDirection {
+  if (!VALID_SORT_DIRECTIONS.includes(value as SortDirection)) {
+    throw new Error(`--sort must be "newest" or "oldest", got "${value}"`);
+  }
+  return value as SortDirection;
+}
+
 /** Default span depth when no value is provided */
 const DEFAULT_SPAN_DEPTH = 3;