refactor(dashboard): co-locate widget types formatter with its command

Move formatWidgetTypes from human.ts into the types.ts command file,
matching the pattern used by dashboard list. Removes the unusual
command→formatter cross-import from human.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: betegon

src/commands/dashboard/widget/types.ts

@@ -7,8 +7,9 @@
 
 import type { SentryContext } from "../../../context.js";
 import { buildCommand } from "../../../lib/command.js";
-import { formatWidgetTypes } from "../../../lib/formatters/human.js";
+import { renderMarkdown } from "../../../lib/formatters/markdown.js";
 import { CommandOutput } from "../../../lib/formatters/output.js";
+import { type Column, writeTable } from "../../../lib/formatters/table.js";
 import {
   AGGREGATE_ALIASES,
   DEFAULT_WIDGET_SIZE,
@@ -21,6 +22,7 @@ import {
   SPAN_AGGREGATE_FUNCTIONS,
   WIDGET_TYPES,
 } from "../../../types/dashboard.js";
+import type { Writer } from "../../../types/index.js";
 
 /** Category classification for display types */
 const DISPLAY_TYPE_CATEGORY: Record<
@@ -59,6 +61,72 @@ export type WidgetTypesResult = {
   aggregateAliases: Record<string, string>;
 };
 
+/**
+ * Format widget types info for human-readable terminal output.
+ *
+ * Renders grid info, a display types table, a datasets table, and
+ * aggregate function summaries.
+ */
+function formatWidgetTypesHuman(result: WidgetTypesResult): string {
+  const parts: string[] = [];
+  const buffer: Writer = { write: (s) => parts.push(s) };
+
+  // Grid header
+  parts.push(renderMarkdown(`**Grid:** ${result.grid.columns} columns`));
+  parts.push("\n");
+
+  // Display types table
+  type DisplayRow = WidgetTypesResult["displayTypes"][number];
+  const dtColumns: Column<DisplayRow>[] = [
+    { header: "DISPLAY TYPE", value: (r) => r.name },
+    { header: "WIDTH:", value: (r) => String(r.defaultWidth), align: "right" },
+    {
+      header: "HEIGHT:",
+      value: (r) => String(r.defaultHeight),
+      align: "right",
+    },
+    { header: "CATEGORY", value: (r) => r.category },
+  ];
+  writeTable(buffer, result.displayTypes, dtColumns);
+
+  parts.push("\n");
+
+  // Datasets table
+  type DatasetRow = WidgetTypesResult["datasets"][number];
+  const dsColumns: Column<DatasetRow>[] = [
+    { header: "DATASET", value: (r) => r.name },
+    { header: "DEFAULT", value: (r) => (r.isDefault ? "✓" : "") },
+  ];
+  writeTable(buffer, result.datasets, dsColumns);
+
+  parts.push("\n");
+
+  // Aggregate functions
+  const aggLines: string[] = [];
+  aggLines.push(
+    `**Aggregates (spans):** ${result.aggregateFunctions.spans.join(", ")}`
+  );
+
+  const spanSet = new Set(result.aggregateFunctions.spans);
+  const discoverOnly = result.aggregateFunctions.discover.filter(
+    (f) => !spanSet.has(f)
+  );
+  if (discoverOnly.length > 0) {
+    aggLines.push(`**Aggregates (discover):** + ${discoverOnly.join(", ")}`);
+  }
+
+  const aliasEntries = Object.entries(result.aggregateAliases);
+  if (aliasEntries.length > 0) {
+    aggLines.push(
+      `**Aliases:** ${aliasEntries.map(([k, v]) => `${k} → ${v}`).join(", ")}`
+    );
+  }
+
+  parts.push(renderMarkdown(aggLines.join("\n")));
+
+  return parts.join("").trimEnd();
+}
+
 export const typesCommand = buildCommand({
   docs: {
     brief: "Show available widget display types and layout info",
@@ -76,7 +144,7 @@ export const typesCommand = buildCommand({
       "  sentry dashboard widget types --json",
   },
   output: {
-    human: formatWidgetTypes,
+    human: formatWidgetTypesHuman,
   },
   parameters: {
     positional: { kind: "array", parameter: { brief: "", parse: String } },

src/lib/formatters/human.ts

@@ -10,7 +10,6 @@
 // biome-ignore lint/performance/noNamespaceImport: Sentry SDK recommends namespace import
 import * as Sentry from "@sentry/node-core/light";
 import prettyMs from "pretty-ms";
-import type { WidgetTypesResult } from "../../commands/dashboard/widget/types.js";
 import type {
   DashboardDetail,
   DashboardWidget,
@@ -2277,66 +2276,3 @@ export function formatWidgetEdited(result: {
   ];
   return renderMarkdown(lines.join("\n"));
 }
-
-/**
- * Format widget types info for human-readable output.
- */
-export function formatWidgetTypes(result: WidgetTypesResult): string {
-  const parts: string[] = [];
-  const buffer: Writer = { write: (s) => parts.push(s) };
-
-  // Grid header
-  parts.push(renderMarkdown(`**Grid:** ${result.grid.columns} columns`));
-  parts.push("\n");
-
-  // Display types table
-  type DisplayRow = WidgetTypesResult["displayTypes"][number];
-  const dtColumns: Column<DisplayRow>[] = [
-    { header: "DISPLAY TYPE", value: (r) => r.name },
-    { header: "WIDTH:", value: (r) => String(r.defaultWidth), align: "right" },
-    {
-      header: "HEIGHT:",
-      value: (r) => String(r.defaultHeight),
-      align: "right",
-    },
-    { header: "CATEGORY", value: (r) => r.category },
-  ];
-  writeTable(buffer, result.displayTypes, dtColumns);
-
-  parts.push("\n");
-
-  // Datasets table
-  type DatasetRow = WidgetTypesResult["datasets"][number];
-  const dsColumns: Column<DatasetRow>[] = [
-    { header: "DATASET", value: (r) => r.name },
-    { header: "DEFAULT", value: (r) => (r.isDefault ? "✓" : "") },
-  ];
-  writeTable(buffer, result.datasets, dsColumns);
-
-  parts.push("\n");
-
-  // Aggregate functions
-  const aggLines: string[] = [];
-  aggLines.push(
-    `**Aggregates (spans):** ${result.aggregateFunctions.spans.join(", ")}`
-  );
-
-  const spanSet = new Set(result.aggregateFunctions.spans);
-  const discoverOnly = result.aggregateFunctions.discover.filter(
-    (f) => !spanSet.has(f)
-  );
-  if (discoverOnly.length > 0) {
-    aggLines.push(`**Aggregates (discover):** + ${discoverOnly.join(", ")}`);
-  }
-
-  const aliasEntries = Object.entries(result.aggregateAliases);
-  if (aliasEntries.length > 0) {
-    aggLines.push(
-      `**Aliases:** ${aliasEntries.map(([k, v]) => `${k} → ${v}`).join(", ")}`
-    );
-  }
-
-  parts.push(renderMarkdown(aggLines.join("\n")));
-
-  return parts.join("").trimEnd();
-}