feat: remove 25 response-type as unknown as casts from API layer (#1090)

Phase 1 of #1068 — eliminates all response-type `as unknown as` casts
from `src/lib/api/` by widening `unwrapResult<T>` and
`unwrapPaginatedResult<T>` to accept `{ data: unknown }` instead of `{
data: T }`. Callers now specify the target type via the generic
parameter rather than casting the return value, centralizing the single
`data as T` cast in `infrastructure.ts`.

**Cast count: 31 → 8** (the remaining 8 are request-body casts,
undocumented-query-param casts, and path-parameter casts for non-numeric
dashboard slugs that require backend spec changes).

Also:
- Removes redundant `result as` casts at `unwrapPaginatedResult` call
sites
- Downgrades `data.event as unknown as SentryEvent` to a single `as
SentryEvent` in `resolveEventInOrg`

## Testing

`tsc --noEmit` passes (only pre-existing errors from missing generated
files). `biome check` passes clean.

Closes #1068

<!--
## Plan

### Problem
30+ `as unknown as` casts in `src/lib/api/` bridge SDK-generated
response types to CLI wrapper types. The runtime shapes match, but the
casts prevent TypeScript from catching regressions.

### Root cause
`unwrapResult<T>` required `{ data: T; error: undefined }` as input,
forcing callers to either:
1. Cast the SDK result to match the local wrapper type before passing it
in
2. Cast the return value after calling unwrapResult

### Fix
Widen the `result` parameter of both `unwrapResult<T>` and
`unwrapPaginatedResult<T>` from `{ data: T; ... }` to `{ data: unknown;
... }`. The functions already cast `data as T` internally, so the
generic `T` now serves purely as the output type — callers specify it at
the call site.

### Files changed
- `infrastructure.ts` — widen `unwrapResult<T>` and
`unwrapPaginatedResult<T>` signatures
- `teams.ts` — 3 response casts removed
- `organizations.ts` — 2 response casts removed
- `events.ts` — 2 response casts removed, 1 downgraded to single `as`
- `releases.ts` — 8 response casts removed, 1 comment removed
- `dashboards.ts` — 3 response casts removed (dashboard_id path-param
casts kept as-is for non-numeric slugs)
- `projects.ts` — 5 response/result casts removed
- `monitors.ts` — 2 casts removed (1 redundant, 1 result-argument)
- `repositories.ts` — 2 casts removed
- `issues.ts` — 1 result-argument cast removed

### Out of scope (Categories 2-3)
- 5 request body casts (need backend OpenAPI spec fixes)
- 1 undocumented `collapse` query param cast (needs spec addition)
- 2 dashboard_id path-param casts (API spec types `number` but accepts
string slugs at runtime)
-->

---------

Co-authored-by: jared-outpost[bot] <jared-outpost[bot]@users.noreply.github.com>
Co-authored-by: jared-outpost[bot] <286517962+jared-outpost[bot]@users.noreply.github.com>

Author: jared-outpost[bot]

src/lib/api/dashboards.ts

@@ -99,8 +99,10 @@ export async function getDashboard(
     },
   });
 
-  const data = unwrapResult(result, `Failed to get dashboard '${dashboardId}'`);
-  return data as unknown as DashboardDetail;
+  return unwrapResult<DashboardDetail>(
+    result,
+    `Failed to get dashboard '${dashboardId}'`
+  );
 }
 
 /**
@@ -124,8 +126,7 @@ export async function createDashboard(
     >[0]["body"],
   });
 
-  const data = unwrapResult(result, "Failed to create dashboard");
-  return data as unknown as DashboardDetail;
+  return unwrapResult<DashboardDetail>(result, "Failed to create dashboard");
 }
 
 /**
@@ -161,11 +162,10 @@ export async function updateDashboard(
     >[0]["body"],
   });
 
-  const data = unwrapResult(
+  return unwrapResult<DashboardDetail>(
     result,
     `Failed to update dashboard '${dashboardId}'`
   );
-  return data as unknown as DashboardDetail;
 }
 
 // ---------------------------------------------------------------------------

src/lib/api/events.ts

@@ -49,8 +49,7 @@ export async function getLatestEvent(
     },
   });
 
-  const data = unwrapResult(result, "Failed to get latest event");
-  return data as unknown as SentryEvent;
+  return unwrapResult<SentryEvent>(result, "Failed to get latest event");
 }
 
 /**
@@ -73,8 +72,7 @@ export async function getEvent(
     },
   });
 
-  const data = unwrapResult(result, "Failed to get event");
-  return data as unknown as SentryEvent;
+  return unwrapResult<SentryEvent>(result, "Failed to get event");
 }
 
 /**
@@ -106,11 +104,15 @@ export async function resolveEventInOrg(
   });
 
   try {
-    const data = unwrapResult(result, "Failed to resolve event ID");
+    const data = unwrapResult<{
+      organizationSlug: string;
+      projectSlug: string;
+      event: unknown;
+    }>(result, "Failed to resolve event ID");
     return {
       org: data.organizationSlug,
       project: data.projectSlug,
-      event: data.event as unknown as SentryEvent,
+      event: data.event as SentryEvent,
     };
   } catch (error) {
     // 404 means the event doesn't exist in this org — not an error

src/lib/api/infrastructure.ts

@@ -228,7 +228,9 @@ export function throwApiError(
  * @returns The data from the successful response
  */
 export function unwrapResult<T>(
-  result: { data: T; error: undefined } | { data: undefined; error: unknown },
+  result:
+    | { data: unknown; error: undefined }
+    | { data: undefined; error: unknown },
   context: string
 ): T {
   const { data, error } = result as {
@@ -265,11 +267,13 @@ export function unwrapResult<T>(
  * @returns Data and optional next-page cursor
  */
 export function unwrapPaginatedResult<T>(
-  result: { data: T; error: undefined } | { data: undefined; error: unknown },
+  result:
+    | { data: unknown; error: undefined }
+    | { data: undefined; error: unknown },
   context: string
 ): PaginatedResponse<T> {
   const response = (result as { response?: Response }).response;
-  const data = unwrapResult(result, context);
+  const data = unwrapResult<T>(result, context);
   const { nextCursor, prevCursor } = parseLinkHeader(
     response?.headers.get("link") ?? null
   );

src/lib/api/issues.ts

@@ -184,12 +184,7 @@ export async function listIssuesPaginated(
     },
   });
 
-  return unwrapPaginatedResult<SentryIssue[]>(
-    result as
-      | { data: SentryIssue[]; error: undefined }
-      | { data: undefined; error: unknown },
-    "Failed to list issues"
-  );
+  return unwrapPaginatedResult<SentryIssue[]>(result, "Failed to list issues");
 }
 
 /** Result from {@link listIssuesAllPages}. */

src/lib/api/monitors.ts

@@ -42,14 +42,12 @@ export async function listMonitors(orgSlug: string): Promise<SentryMonitor[]> {
       },
     });
     return unwrapPaginatedResult<SentryMonitor[]>(
-      result as
-        | { data: SentryMonitor[]; error: undefined }
-        | { data: undefined; error: unknown },
+      result,
       "Failed to list monitors"
     );
   }, MAX_PAGINATION_PAGES * API_MAX_PER_PAGE);
 
-  return allResults as unknown as SentryMonitor[];
+  return allResults;
 }
 
 /**

src/lib/api/organizations.ts

@@ -62,7 +62,10 @@ export async function listOrganizationsInRegion(
 
   // 403 enrichment (CLI-89, 24 users) is now handled centrally by
   // throwApiError() in infrastructure.ts — no per-endpoint catch needed.
-  const data = unwrapResult(result, "Failed to list organizations");
+  const data = unwrapResult<SentryOrganization[]>(
+    result,
+    "Failed to list organizations"
+  );
   if (!Array.isArray(data)) {
     throw new ApiError(
       "Failed to list organizations: unexpected response format",
@@ -71,7 +74,7 @@ export async function listOrganizationsInRegion(
         "This may indicate an incompatible self-hosted Sentry version or a proxy interfering with the response."
     );
   }
-  return data as unknown as SentryOrganization[];
+  return data;
 }
 
 /**
@@ -211,6 +214,5 @@ export async function getOrganization(
     path: { organization_id_or_slug: orgSlug },
   });
 
-  const data = unwrapResult(result, "Failed to get organization");
-  return data as unknown as SentryOrganization;
+  return unwrapResult<SentryOrganization>(result, "Failed to get organization");
 }

src/lib/api/projects.ts

@@ -66,9 +66,7 @@ export async function listProjects(orgSlug: string): Promise<SentryProject[]> {
       },
     });
     return unwrapPaginatedResult<SentryProject[]>(
-      result as
-        | { data: SentryProject[]; error: undefined }
-        | { data: undefined; error: unknown },
+      result,
       "Failed to list projects"
     );
   }, MAX_PAGINATION_PAGES * API_MAX_PER_PAGE);
@@ -111,9 +109,7 @@ export async function listProjectsPaginated(
   });
 
   return unwrapPaginatedResult<SentryProject[]>(
-    result as
-      | { data: SentryProject[]; error: undefined }
-      | { data: undefined; error: unknown },
+    result,
     "Failed to list projects"
   );
 }
@@ -154,8 +150,7 @@ export async function createProject(
     },
     body,
   });
-  const data = unwrapResult(result, "Failed to create project");
-  return data as unknown as SentryProject;
+  return unwrapResult<SentryProject>(result, "Failed to create project");
 }
 
 /** Result of creating a project and fetching its DSN + dashboard URL. */
@@ -548,8 +543,7 @@ export async function getProject(
     | { data: unknown; error: undefined }
     | { data: undefined; error: unknown };
 
-  const data = unwrapResult(result, "Failed to get project");
-  return data as unknown as SentryProject;
+  return unwrapResult<SentryProject>(result, "Failed to get project");
 }
 
 /**
@@ -600,8 +594,7 @@ export async function getProjectKeys(
     },
   });
 
-  const data = unwrapResult(result, "Failed to get project keys");
-  return data as unknown as ProjectKey[];
+  return unwrapResult<ProjectKey[]>(result, "Failed to get project keys");
 }
 
 /**

src/lib/api/releases.ts

@@ -31,10 +31,6 @@ import {
 import { getProject } from "./projects.js";
 import { listRepositoriesPaginated } from "./repositories.js";
 
-// We cast through `unknown` to bridge the gap between the SDK's internal
-// return types and the public response types — the shapes are compatible
-// at runtime.
-
 /**
  * List releases in an organization with pagination control.
  * Returns a single page of results with cursor metadata.
@@ -98,9 +94,7 @@ export async function listReleasesPaginated(
   });
 
   return unwrapPaginatedResult<SentryRelease[]>(
-    result as
-      | { data: SentryRelease[]; error: undefined }
-      | { data: undefined; error: unknown },
+    result,
     "Failed to list releases"
   );
 }
@@ -190,8 +184,10 @@ export async function getRelease(
     },
   });
 
-  const data = unwrapResult(result, `Failed to get release '${version}'`);
-  return data as unknown as SentryRelease;
+  return unwrapResult<SentryRelease>(
+    result,
+    `Failed to get release '${version}'`
+  );
 }
 
 /**
@@ -233,10 +229,9 @@ export async function createRelease(
 
   // 208 = release already exists (idempotent) — treat as success
   if (result.data) {
-    return result.data as unknown as SentryRelease;
+    return result.data as SentryRelease;
   }
-  const data = unwrapResult(result, "Failed to create release");
-  return data as unknown as SentryRelease;
+  return unwrapResult<SentryRelease>(result, "Failed to create release");
 }
 
 /**
@@ -279,8 +274,10 @@ export async function updateRelease(
     >[0]["body"],
   });
 
-  const data = unwrapResult(result, `Failed to update release '${version}'`);
-  return data as unknown as SentryRelease;
+  return unwrapResult<SentryRelease>(
+    result,
+    `Failed to update release '${version}'`
+  );
 }
 
 /**
@@ -327,11 +324,10 @@ export async function listReleaseDeploys(
     },
   });
 
-  const data = unwrapResult(
+  return unwrapResult<SentryDeploy[]>(
     result,
     `Failed to list deploys for release '${version}'`
   );
-  return data as unknown as SentryDeploy[];
 }
 
 /**
@@ -364,8 +360,7 @@ export async function createReleaseDeploy(
     body: body as unknown as Parameters<typeof createADeploy>[0]["body"],
   });
 
-  const data = unwrapResult(result, "Failed to create deploy");
-  return data as unknown as SentryDeploy;
+  return unwrapResult<SentryDeploy>(result, "Failed to create deploy");
 }
 
 /**
@@ -582,6 +577,8 @@ export async function listProjectEnvironments(
     },
     query: { visibility: "visible" },
   });
-  const data = unwrapResult(result, "Failed to list environments");
-  return data as unknown as ProjectEnvironment[];
+  return unwrapResult<ProjectEnvironment[]>(
+    result,
+    "Failed to list environments"
+  );
 }

src/lib/api/repositories.ts

@@ -39,8 +39,10 @@ export async function listRepositories(
     path: { organization_id_or_slug: orgSlug },
   });
 
-  const data = unwrapResult(result, "Failed to list repositories");
-  return data as unknown as SentryRepository[];
+  return unwrapResult<SentryRepository[]>(
+    result,
+    "Failed to list repositories"
+  );
 }
 
 /**
@@ -67,9 +69,7 @@ export async function listRepositoriesPaginated(
   });
 
   return unwrapPaginatedResult<SentryRepository[]>(
-    result as
-      | { data: SentryRepository[]; error: undefined }
-      | { data: undefined; error: unknown },
+    result,
     "Failed to list repositories"
   );
 }

src/lib/api/teams.ts

@@ -36,8 +36,7 @@ export async function listTeams(orgSlug: string): Promise<SentryTeam[]> {
     path: { organization_id_or_slug: orgSlug },
   });
 
-  const data = unwrapResult(result, "Failed to list teams");
-  return data as unknown as SentryTeam[];
+  return unwrapResult<SentryTeam[]>(result, "Failed to list teams");
 }
 
 /**
@@ -88,8 +87,7 @@ export async function listProjectTeams(
       project_id_or_slug: projectSlug,
     },
   });
-  const data = unwrapResult(result, "Failed to list project teams");
-  return data as unknown as SentryTeam[];
+  return unwrapResult<SentryTeam[]>(result, "Failed to list project teams");
 }
 
 /**
@@ -114,8 +112,7 @@ export async function createTeam(
     path: { organization_id_or_slug: orgSlug },
     body: { slug },
   });
-  const data = unwrapResult(result, "Failed to create team");
-  const team = data as unknown as SentryTeam;
+  const team = unwrapResult<SentryTeam>(result, "Failed to create team");
 
   // Best-effort: add the current user to the team
   try {