fix: address PR review comments for positional args refactor

- Fix foundProject.organization?.slug bug (use orgSlug instead)
- Make formatMultipleProjectsFooter generic (not hardcoded to issue list)
- Fix ContextError misuse producing garbled messages:
  - Use ValidationError for 'multiple orgs' error
  - Use ValidationError for 'invalid target' error
  - Use noun phrase 'Specific project' for OrgAll case
- Update dsn/errors.ts to use generic 'sentry <command>' in hints
- Update test expectations to match new messages

Author: BYK

src/commands/event/view.ts

@@ -13,7 +13,7 @@ import {
   spansFlag,
 } from "../../lib/arg-parsing.js";
 import { openInBrowser } from "../../lib/browser.js";
-import { ContextError } from "../../lib/errors.js";
+import { ContextError, ValidationError } from "../../lib/errors.js";
 import { formatEventDetails, writeJson } from "../../lib/formatters/index.js";
 import { resolveOrgAndProject } from "../../lib/resolve-target.js";
 import { buildEventSearchUrl } from "../../lib/sentry-urls.js";
@@ -116,30 +116,19 @@ async function resolveFromProjectSearch(
     ]);
   }
   if (found.length > 1) {
-    const alternatives = found.map(
-      (p) => `${p.organization?.slug ?? "unknown"}/${p.slug}`
-    );
-    throw new ContextError(
-      `Project "${projectSlug}" exists in multiple organizations`,
-      `sentry event view <org>/${projectSlug} ${eventId}`,
-      alternatives
-    );
-  }
-  const foundProject = found[0];
-  if (!foundProject) {
-    throw new ContextError(`Project "${projectSlug}" not found`, USAGE_HINT);
-  }
-  const orgSlug = foundProject.organization?.slug;
-  if (!orgSlug) {
-    throw new ContextError(
-      `Could not determine organization for project "${projectSlug}"`,
-      USAGE_HINT
+    const orgList = found.map((p) => `  ${p.orgSlug}/${p.slug}`).join("\n");
+    throw new ValidationError(
+      `Project "${projectSlug}" exists in multiple organizations.\n\n` +
+        `Specify the organization:\n${orgList}\n\n` +
+        `Example: sentry event view <org>/${projectSlug} ${eventId}`
     );
   }
+  // Safe assertion: length is exactly 1 after the checks above
+  const foundProject = found[0] as (typeof found)[0];
   return {
-    org: orgSlug,
+    org: foundProject.orgSlug,
     project: foundProject.slug,
-    orgDisplay: orgSlug,
+    orgDisplay: foundProject.orgSlug,
     projectDisplay: foundProject.slug,
   };
 }
@@ -207,18 +196,15 @@ export const viewCommand = buildCommand({
         break;
 
       case ProjectSpecificationType.OrgAll:
-        throw new ContextError(
-          "A specific project is required for event view",
-          USAGE_HINT
-        );
+        throw new ContextError("Specific project", USAGE_HINT);
 
       case ProjectSpecificationType.AutoDetect:
         target = await resolveOrgAndProject({ cwd, usageHint: USAGE_HINT });
         break;
 
       default:
         // Exhaustive check - should never reach here
-        throw new ContextError("Invalid target specification", USAGE_HINT);
+        throw new ValidationError("Invalid target specification");
     }
 
     if (!target) {

src/lib/dsn/errors.ts

@@ -31,7 +31,7 @@ export function formatConflictError(result: DsnDetectionResult): string {
   });
 
   lines.push("To resolve, specify which project to use:");
-  lines.push("  sentry issue list <org>/<project>");
+  lines.push("  sentry <command> <org>/<project>");
   lines.push("");
   lines.push("Or set a default project:");
   lines.push("  sentry config set defaults.org <org>");
@@ -91,7 +91,7 @@ export async function formatNoDsnError(
   );
   lines.push("");
   lines.push("3. Specify project explicitly:");
-  lines.push("   sentry issue list <org>/<project>");
+  lines.push("   sentry <command> <org>/<project>");
   lines.push("");
   lines.push("4. Set default project:");
   lines.push("   sentry config set defaults.org <org>");
@@ -119,7 +119,7 @@ export function formatResolutionError(error: Error, dsnRaw: string): string {
     "  - The DSN is invalid or expired",
     "",
     "Try specifying the project explicitly:",
-    "  sentry issue list <org>/<project>",
+    "  sentry <command> <org>/<project>",
   ];
 
   return lines.join("\n");
@@ -147,7 +147,7 @@ type ProjectInfo = {
  * Found 2 Sentry projects:
  *   • my-org / frontend (from packages/frontend/.env)
  *   • my-org / backend (from src/sentry.ts)
- * Specify a project: sentry issue list <org>/<project>
+ * Use <org>/<project> to target a specific project.
  * ```
  */
 export function formatMultipleProjectsFooter(projects: ProjectInfo[]): string {
@@ -162,7 +162,7 @@ export function formatMultipleProjectsFooter(projects: ProjectInfo[]): string {
     lines.push(`  • ${p.orgDisplay} / ${p.projectDisplay}${source}`);
   }
 
-  lines.push("Specify a project: sentry issue list <org>/<project>");
+  lines.push("Use <org>/<project> to target a specific project.");
 
   return lines.join("\n");
 }

test/lib/dsn/errors.test.ts

@@ -59,7 +59,7 @@ describe("formatConflictError", () => {
     expect(error).toContain("def456@o789.ingest.sentry.io/101112");
     expect(error).toContain("Project ID: 456");
     expect(error).toContain("Project ID: 101112");
-    expect(error).toContain("sentry issue list <org>/<project>");
+    expect(error).toContain("sentry <command> <org>/<project>");
     expect(error).toContain("sentry config set defaults.org");
   });
 
@@ -183,7 +183,7 @@ describe("formatNoDsnError", () => {
     expect(error).toContain(".env files");
     expect(error).toContain("JavaScript/TypeScript source code");
     expect(error).toContain("export SENTRY_DSN=");
-    expect(error).toContain("sentry issue list <org>/<project>");
+    expect(error).toContain("sentry <command> <org>/<project>");
     expect(error).toContain("sentry config set defaults.org");
   });
 
@@ -245,7 +245,7 @@ describe("formatResolutionError", () => {
     expect(formatted).toContain("You don't have access to this project");
     expect(formatted).toContain("self-hosted Sentry instance");
     expect(formatted).toContain("invalid or expired");
-    expect(formatted).toContain("sentry issue list <org>/<project>");
+    expect(formatted).toContain("sentry <command> <org>/<project>");
   });
 
   test("formats error with access denied message", () => {
@@ -302,7 +302,7 @@ describe("formatMultipleProjectsFooter", () => {
     );
     expect(footer).toContain("• my-org / backend (from src/sentry.ts)");
     expect(footer).toContain(
-      "Specify a project: sentry issue list <org>/<project>"
+      "Use <org>/<project> to target a specific project."
     );
   });