You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs(validate-pr): Drop version-tag references in favor of SHA pinning
Consumers in getsentry/* pin this action by commit SHA, not by @v* tags
or major-version moving tags. Update the README example and the
"updating earlier revisions" section to reflect that. Drop the
"Breaking changes" framing in the changelog — the action has not
shipped in a tagged release, so calling it a breaking change overstates
the impact.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1-4Lines changed: 1 addition & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,12 +2,9 @@
2
2
3
3
## Unreleased
4
4
5
-
### Breaking changes
6
-
7
-
- Validate PR - Major v4 release: action is now advisory. PRs are no longer closed, and no labels are applied. Instead, a single friendly comment is posted on community PRs that don't reference an issue with maintainer discussion. The `was-closed` output has been removed. Recommended trigger is now `types: [opened]` (drop `reopened`). Pin to `@v3` to keep the previous closing behavior.
8
-
9
5
### Features
10
6
7
+
- Validate PR - Action is advisory: it posts a single friendly comment on community PRs that don't reference an issue with maintainer discussion. PRs are not closed and no labels are applied. Recommended trigger is `types: [opened]`.
11
8
- Validate PR - Skip validation for PRs with fewer than 100 lines changed, excluding common lock files (`Cargo.lock`, `yarn.lock`, `package-lock.json`, `Pipfile.lock`, etc.). Tiny PRs no longer go through the issue-discussion loop.
12
9
- Add validate-pr composite action for validating non-maintainer PRs against contribution guidelines ([#153](https://github.com/getsentry/github-workflows/pull/153))
The `pull-requests: write` permission is needed because the action posts comments on the PR.
34
+
Pin to a specific commit SHA (consumers in `getsentry/*` already follow this convention). The `pull-requests: write` permission is needed because the action posts comments on the PR.
35
35
36
36
## Inputs
37
37
@@ -83,14 +83,14 @@ The PR is considered compliant if **any** referenced issue passes all of:
83
83
84
84
If no referenced issue passes, the action posts one advisory comment. The PR remains open and reviewable; no labels or status checks are applied. The comment is idempotent — workflow re-runs on the same PR will not produce duplicates.
85
85
86
-
## Migrating from v3
86
+
## Updating from earlier revisions
87
87
88
-
v3 closed non-compliant PRs and applied labels (`violating-contribution-guidelines`, `missing-issue-reference`, `missing-maintainer-discussion`, `issue-already-assigned`). v4 does neither — it only posts a comment.
88
+
Earlier revisions of this action closed non-compliant PRs and applied labels (`violating-contribution-guidelines`, `missing-issue-reference`, `missing-maintainer-discussion`, `issue-already-assigned`). The current version does neither — it only posts a comment.
0 commit comments