merge branch

Author: lucas-zimerman

.github/workflows/danger.yml

@@ -0,0 +1,56 @@
+# Runs DangerJS with a pre-configured set of rules on a Pull Request.
+on:
+  workflow_call:
+    inputs:
+      _workflow_version:
+        description: 'Internal: specify github-workflows (this repo) revision to use when checking out scripts.'
+        type: string
+        required: false
+        default: v2 # Note: update when publishing a new version
+      extra-dangerfile:
+        description: 'Path to additional dangerfile to run after the main checks'
+        type: string
+        required: false
+    outputs:
+      outcome:
+        description: Whether the Danger run finished successfully. Possible values are success, failure, cancelled, or skipped.
+        value: ${{ jobs.danger.outputs.outcome }}
+
+jobs:
+  danger:
+    runs-on: ubuntu-latest
+    outputs:
+      outcome: ${{ steps.danger.outcome }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Download dangerfile.js
+        run: wget https://raw.githubusercontent.com/lucas-zimerman/sentry-github-workflows/refs/heads/lz/ext-danger/danger/dangerfile.js -P ${{ runner.temp }}
+
+      - name: Download external dangerfile (if provided)
+        if: inputs.extra-dangerfile
+        run: |
+          # Download the external dangerfile from the calling repository
+          wget "https://raw.githubusercontent.com/${{ github.repository }}/${{ github.head_ref || github.ref_name }}/${{ inputs.extra-dangerfile }}" -P ${{ runner.temp }}
+          echo "Downloaded external dangerfile: ${{ inputs.extra-dangerfile }}"
+
+      # Using a pre-built docker image in GitHub container registry instaed of NPM to reduce possible attack vectors.
+      - name: Run DangerJS
+        id: danger
+        run: |
+          docker run \
+            --rm \
+            --interactive \
+            --volume ${{ github.workspace }}:/github/workspace \
+            --volume ${{ runner.temp }}:${{ runner.temp }} \
+            --workdir /github/workspace \
+            --user root \
+            -e "INPUT_ARGS" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true \
+            -e GITHUB_TOKEN="${{ github.token }}" \
+            -e DANGER_DISABLE_TRANSPILATION="true" \
+            -e EXTRA_DANGERFILE_INPUT="${{ inputs.extra-dangerfile }}" \
+            -e RUNNER_TEMP="${{ runner.temp }}" \
+            ghcr.io/danger/danger-js:13.0.1 \
+            --failOnErrors --dangerfile ${{ runner.temp }}/dangerfile.js

danger/dangerfile.js

@@ -193,6 +193,7 @@ async function CheckFromExternalChecks() {
   console.log(`::debug:: Checking from external checks: ${customPath}`);
   if (customPath) {
     try {
+
       const extraModule = require(customPath);
 
       if (typeof extraModule === "function") {
@@ -208,7 +209,11 @@ async function CheckFromExternalChecks() {
         await extraModule.default();
       }
     } catch (err) {
-      warn(`Could not load custom Dangerfile: ${customPath}\n${err}`);
+      if (err.message && err.message.includes('Cannot use import statement outside a module')) {
+        warn(`External dangerfile uses ES6 imports. Please convert to CommonJS syntax (require/module.exports) or use .mjs extension with proper module configuration.\nFile: ${customPath}`);
+      } else {
+        warn(`Could not load custom Dangerfile: ${customPath}\n${err}`);
+      }
     }
   }
 }