fix(core): clear delegated credentials on retarget

Author: dcramer

packages/junior/src/chat/tools/event-tasks.ts

@@ -140,6 +140,21 @@ function cleanEvents(events: string[]): string[] {
   return clean;
 }
 
+function changesTriggerSource(
+  current: EventTask["trigger"],
+  next: EventTask["trigger"],
+): boolean {
+  const currentEvents = [...current.events].sort();
+  const nextEvents = [...next.events].sort();
+  return (
+    current.provider !== next.provider ||
+    current.resourceRef !== next.resourceRef ||
+    current.resourceType !== next.resourceType ||
+    currentEvents.length !== nextEvents.length ||
+    currentEvents.some((event, index) => event !== nextEvents[index])
+  );
+}
+
 function nextUpdatedAtMs(task: EventTask): number {
   return Math.max(Date.now(), task.updatedAtMs + 1);
 }
@@ -316,24 +331,26 @@ export function createUpdateEventTaskTool(context: ToolRuntimeContext) {
       ) {
         throw new ToolInputError("Event task update requires a change.");
       }
+      const nextTrigger = input.trigger
+        ? {
+            provider: input.trigger.provider,
+            resourceRef: input.trigger.resourceRef,
+            resourceType: input.trigger.resourceType,
+            label: input.trigger.label,
+            events: cleanEvents(input.trigger.events),
+          }
+        : current.trigger;
       const changesExecution =
-        input.task !== undefined && input.task !== current.task.text;
+        (input.task !== undefined && input.task !== current.task.text) ||
+        changesTriggerSource(current.trigger, nextTrigger);
       const next: EventTask = {
         ...current,
         credentialMode:
           changesExecution && !isCreator
             ? "system"
             : (input.credentialMode ?? current.credentialMode),
         task: input.task ? { text: input.task } : current.task,
-        trigger: input.trigger
-          ? {
-              provider: input.trigger.provider,
-              resourceRef: input.trigger.resourceRef,
-              resourceType: input.trigger.resourceType,
-              label: input.trigger.label,
-              events: cleanEvents(input.trigger.events),
-            }
-          : current.trigger,
+        trigger: nextTrigger,
         updatedAtMs: nextUpdatedAtMs(current),
       };
       const saved = await updateActiveEventTask(

packages/junior/tests/integration/event-tasks.test.ts

@@ -197,6 +197,22 @@ describe("event tasks", () => {
       credentialMode: "creator",
       trigger: { label: "Updated GitHub PR label" },
     });
+    await execute(createUpdateEventTaskTool(context("U999")), {
+      taskId: first.task.id,
+      trigger: {
+        provider: "github",
+        resourceRef: "github:pull_request:getsentry/junior#1176",
+        resourceType: "pull_request",
+        label: "GitHub PR getsentry/junior#1176",
+        events: ["review.changes_requested"],
+      },
+    });
+    expect(await getEventTask(fixture.sql.db(), first.task.id)).toMatchObject({
+      credentialMode: "system",
+      trigger: {
+        resourceRef: "github:pull_request:getsentry/junior#1176",
+      },
+    });
     await expect(
       execute(createUpdateEventTaskTool(context("U999")), {
         taskId: first.task.id,