ref(plugin-api)!: standardize source visibility (#1183)

## Summary

- replace `Source.type: "pub" | "priv"` with `Source.visibility:
"public" | "private"`
- hard-cut runtime, plugin, scheduler, memory, test, and eval consumers
to the canonical vocabulary
- migrate persisted conversation `source_json` records to the new field
and values

This PR is stacked on #1182 and should be retargeted to `main` after
that PR merges.

## Breaking change

Plugin authors must update source construction and reads from
`type`/`pub`/`priv` to `visibility`/`public`/`private`. There is no
compatibility reader; durable conversation records are upgraded by the
included SQL migration.

## Testing

- `pnpm typecheck`
- `pnpm --filter @sentry/junior exec vitest run
tests/unit/plugin-api-source.test.ts tests/unit/runtime/source.test.ts
tests/unit/plugins/agent-hooks.test.ts
tests/integration/heartbeat.test.ts
tests/integration/slack-schedule-tools.test.ts
tests/integration/conversation-sql.test.ts` (118 tests)
- `pnpm --filter @sentry/junior-memory test` (89 tests)
- `pnpm --filter @sentry/junior-github exec vitest run
tests/github-plugin.test.ts` (73 tests)
- `pnpm --filter @sentry/junior-plugin-api build`
- `pnpm --filter @sentry/junior-scheduler build`
- `pnpm lint` passed all source and architecture checks; the final
`publint` packaging step failed locally because it could not find pnpm's
tarball despite `pnpm pack` exiting successfully

Author: dcramer

packages/junior-evals/evals/memory/helpers.ts

@@ -43,7 +43,7 @@ export async function seedMemory(args: {
       messageTs: args.thread.thread_ts,
       teamId: memoryTeamId,
       threadTs: args.thread.thread_ts,
-      type: args.thread.channel_type === "channel" ? "pub" : "priv",
+      visibility: args.thread.channel_type === "channel" ? "public" : "private",
     }),
   });
   const input = {

packages/junior-evals/evals/memory/personal.eval.ts

@@ -196,7 +196,7 @@ describeEval("Personal Memory", slackEvals, (it) => {
         teamId: memoryTeamId,
         threadTs: "17000000.000003",
 
-        type: "priv",
+        visibility: "private",
       }),
     };
 

packages/junior-github/tests/github-plugin.test.ts

@@ -324,7 +324,7 @@ function githubToolsContext(input?: {
     destination: { platform: "local" as const, conversationId },
     source: {
       platform: "local" as const,
-      type: "priv" as const,
+      visibility: "private" as const,
       conversationId,
     },
     embedder: {},

packages/junior-memory/src/personal.ts

@@ -57,7 +57,7 @@ function runtimeContext(actor: PluginUserPageActor): MemoryRuntimeContext {
       actor,
       source: {
         platform: "slack",
-        type: "priv",
+        visibility: "private",
         teamId: actor.teamId,
         channelId: "DDASHBOARD",
       },
@@ -67,15 +67,18 @@ function runtimeContext(actor: PluginUserPageActor): MemoryRuntimeContext {
     actor,
     source: {
       platform: "local",
-      type: "priv",
+      visibility: "private",
       conversationId: "local:dashboard:memories",
     },
   };
 }
 
 function decodeCursor(
   value: string | undefined,
-  input: Pick<ViewerMemoryPageInput, "kind" | "origin" | "query" | "visibility">,
+  input: Pick<
+    ViewerMemoryPageInput,
+    "kind" | "origin" | "query" | "visibility"
+  >,
 ) {
   if (!value) return undefined;
   try {
@@ -98,7 +101,10 @@ function decodeCursor(
 
 function encodeCursor(
   cursor: { createdAtMs: number; id: string },
-  input: Pick<ViewerMemoryPageInput, "kind" | "origin" | "query" | "visibility">,
+  input: Pick<
+    ViewerMemoryPageInput,
+    "kind" | "origin" | "query" | "visibility"
+  >,
 ): string {
   return Buffer.from(
     JSON.stringify({

packages/junior-memory/tests/retrieval-quality.test.ts

@@ -74,7 +74,7 @@ function runtimeContext() {
       messageTs: threadTs,
       teamId,
       threadTs,
-      type: "pub",
+      visibility: "public",
     }),
   };
 }

packages/junior-memory/tests/storage.test.ts

@@ -371,7 +371,7 @@ function slackContext(
       channelId,
       // The Slack boundary supplies normalized public visibility for these
       // C-prefixed test channels unless a test overrides the channel id.
-      type: channelId.startsWith("C") ? "pub" : "priv",
+      visibility: channelId.startsWith("C") ? "public" : "private",
       messageTs: threadTs,
       threadTs,
     }),
@@ -1602,7 +1602,7 @@ describe("memory plugin storage", () => {
                   teamId: runtime.source.teamId,
                   channelId: runtime.source.channelId,
 
-                  type: "priv",
+                  visibility: "private",
                 }),
               });
             },
@@ -3547,7 +3547,7 @@ WHERE id = '${superseded.memory.id}'
           },
           source: {
             platform: "slack",
-            type: "pub",
+            visibility: "public",
             teamId: "T123",
             channelId: "C123",
             messageTs: "1718800000.000000",

packages/junior-plugin-api/src/context.ts

@@ -19,7 +19,7 @@ export type SystemActor = z.output<typeof systemActorSchema>;
 export type Source = z.output<typeof sourceSchema>;
 export type SlackSource = Extract<Source, { platform: "slack" }>;
 export type LocalSource = Extract<Source, { platform: "local" }>;
-export type SourceType = Source["type"];
+export type SourceVisibility = Source["visibility"];
 
 export type Destination = z.output<typeof destinationSchema>;
 
@@ -103,11 +103,11 @@ export function createSlackSource(input: {
   teamId: string;
   threadTs?: string;
   /** Runtime-normalized source visibility. */
-  type: SourceType;
+  visibility: SourceVisibility;
 }): SlackSource {
   return {
     platform: "slack",
-    type: input.type,
+    visibility: input.visibility,
     teamId: input.teamId,
     channelId: input.channelId,
     ...(input.messageTs ? { messageTs: input.messageTs } : {}),
@@ -119,14 +119,14 @@ export function createSlackSource(input: {
 export function createLocalSource(conversationId: string): LocalSource {
   return {
     platform: "local",
-    type: "priv",
+    visibility: "private",
     conversationId,
   };
 }
 
 /** Return whether a source is private to a person or restricted group. */
 export function isPrivateSource(source: Source): boolean {
-  return source.type === "priv";
+  return source.visibility === "private";
 }
 
 /** Return the stable source identity used for idempotency and attribution. */

packages/junior-plugin-api/src/schemas.ts

@@ -23,7 +23,7 @@ const exactNonBlankStringSchema = nonBlankStringSchema.refine(
 export const platformSchema = z.enum(["slack", "local"]);
 
 /** Runtime source visibility visible to plugins. */
-export const sourceTypeSchema = z.enum(["pub", "priv"]);
+export const sourceVisibilitySchema = z.enum(["public", "private"]);
 
 /** Provider-neutral visibility of a routed destination. */
 export const destinationVisibilitySchema = z.enum(["public", "private"]);
@@ -56,7 +56,7 @@ export const destinationSchema = z.discriminatedUnion("platform", [
 /** Runtime-owned Slack coordinates for the inbound invocation. */
 export const slackSourceSchema = slackAddressSchema
   .extend({
-    type: sourceTypeSchema,
+    visibility: sourceVisibilitySchema,
     messageTs: nonBlankStringSchema.optional(),
     threadTs: nonBlankStringSchema.optional(),
   })
@@ -66,7 +66,7 @@ export const slackSourceSchema = slackAddressSchema
 export const localSourceSchema = z
   .object({
     platform: z.literal("local"),
-    type: z.literal("priv"),
+    visibility: z.literal("private"),
     conversationId: localConversationIdSchema,
   })
   .strict();

packages/junior-scheduler/src/plugin.ts

@@ -81,7 +81,8 @@ function scheduledTaskDispatchSource(task: ScheduledTask): Source {
   return createSlackSource({
     teamId: task.destination.teamId,
     channelId: task.destination.channelId,
-    type: task.conversationAccess?.visibility === "public" ? "pub" : "priv",
+    visibility:
+      task.conversationAccess?.visibility === "public" ? "public" : "private",
   });
 }
 

packages/junior-scheduler/src/tool-support.ts

@@ -164,7 +164,7 @@ export function getConversationAccess(
   }
   return {
     audience: "channel",
-    visibility: source?.type === "pub" ? "public" : "private",
+    visibility: source?.visibility === "public" ? "public" : "private",
   };
 }