Skip to content

Commit 9f8e193

Browse files
docs(github-code): Add PR lifecycle subscription step after PR creation (#740)
Adds a new Step 7 "Subscribe to PR lifecycle" to the `github-code` skill workflow, inserted between PR creation and the final report step. After `github_createPullRequest` returns, the skill now checks for a subscribable resource hint and calls `subscribeToResourceEvents` if one is present. The intent is self-contained — it captures repo, PR number, branch, and per-event-class instructions: - **Review feedback** → load `pr-cleanup`, address validated feedback, push, report - **CI failure** → load `pr-cleanup`, trace root cause from logs, fix, push, report - **CI green** (after prior failure) → confirm unblocked, summarize state If no subscribable hint is present, the step is a no-op. The prior Step 7 (Report result) becomes Step 8. <!-- junior-session-footer:start --> -- [View Junior Session in Sentry](https://sentry.sentry.io/explore/conversations/slack%3AC0B595QDZLL%3A1783026294.471609/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
1 parent 7975232 commit 9f8e193

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

  • packages/junior-github/skills/github-code

packages/junior-github/skills/github-code/SKILL.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,17 @@ Defaults:
132132

133133
**Assignment:** resolve GitHub handles from evidence (`gh api search/users`, org membership, repo history) before assigning requested reviewers or assignees. Skip assignment when the handle cannot be confirmed.
134134

135-
### 7. Report result
135+
### 7. Subscribe to PR lifecycle
136+
137+
After `github_createPullRequest` succeeds, check whether the result includes a subscribable resource hint. If it does, call `subscribeToResourceEvents` immediately before reporting.
138+
139+
- Use the suggested events from the hint; when absent, request review and CI events.
140+
- Write a **self-contained intent** that captures repo, PR number, branch, and a single goal: resolve any review concerns and keep the build green. When an event fires, read the signal, address it, push, and report.
141+
- **Only post an update when there is something meaningful to say.** Report when feedback has been addressed, a build failure has been fixed, the PR is fully green and ready to merge, or the PR has been merged. Stay silent on intermediate CI passes, queued checks, and informational events with no action taken.
142+
143+
If no subscribable hint is present, skip this step.
144+
145+
### 8. Report result
136146

137147
Return: repo, branch, PR URL/number (when applicable), checks run with results, pre-existing failures if any, checks not run and why.
138148

0 commit comments

Comments
 (0)