ref(core): remove event task status projection

Author: dcramer

packages/docs/src/content/docs/extend/github-plugin.md

@@ -135,7 +135,8 @@ When `GITHUB_WEBHOOK_SECRET` is configured, GitHub tools can return subscribable
 pull request and issue resources. Junior can use those resources in two ways. A
 temporary resource watch sends matching updates back to the current Slack
 thread. A durable event task runs a stored instruction whenever its selected
-events occur and remains active for the Slack channel until someone deletes it.
+events occur and remains configured for the Slack channel until someone deletes
+it.
 
 Both forms run headlessly as Junior, not as the webhook sender. Resource watches
 use the plugin's scoped installation credentials. Event tasks make their
@@ -159,7 +160,7 @@ Supported GitHub webhook deliveries become these Junior resource events:
 `pull_request.merged` and `pull_request.closed_unmerged` complete a temporary
 pull request watch after Junior accepts the event. Other watch events remain
 active until the watch expires or is cancelled. Event tasks do not complete
-after a terminal event; they remain active until deleted.
+after a terminal event; they remain configured until deleted.
 
 Issue events can target one issue with `owner/repo#number` or every issue in a
 repository with `owner/repo`. Webhook events use normal queued delivery. They do
@@ -271,7 +272,7 @@ expected follow-up in the original conversation.
 - Deployment metadata is available but Junior never offers to watch it: `GITHUB_WEBHOOK_SECRET` is missing. Set it, redeploy, and run `github_getDeployment` again.
 - GitHub webhook delivery returns `401`: the webhook secret in GitHub App settings does not match `GITHUB_WEBHOOK_SECRET`, or GitHub did not send `X-Hub-Signature-256`. Update the app webhook secret and retry the delivery.
 - GitHub webhook delivery returns `202 Ignored`: the delivery was signed correctly but does not map to a supported deployment, pull request, or issue event. Use one of the configured event types above.
-- GitHub delivery succeeds but no Slack follow-up appears: confirm the destination has an active resource watch or event task for the same identifier and event type. A successful webhook alone does not create either one.
+- GitHub delivery succeeds but no Slack follow-up appears: confirm the destination has a resource watch or event task for the same identifier and event type. A successful webhook alone does not create either one.
 - Missing repository context: Junior could not determine which repository to use. Include `owner/repo` directly in the GitHub request, or configure a default GitHub repository for that thread, and retry.
 - A `403` response that says to use `github_createIssue` or `github_createPullRequest` is a Junior routing denial, not evidence of missing App permissions. Retry with the named tool.
 - Private OAuth prompt for a human-identity operation such as a pull request review: the actor has not authorized the GitHub App yet, or the stored user-to-server token expired. Complete the private authorization prompt; do not paste personal access tokens into the chat or sandbox.

packages/junior-evals/evals/event-tasks/management.eval.ts

@@ -257,7 +257,7 @@ describeEval("Event Task Management", slackEvals, (it) => {
         pass: [
           "The assistant first identifies the issue event task created for this channel even though the request comes from another thread.",
           "The assistant updates that task to react only to issue reopenings and confirms the new behavior.",
-          "The assistant then deletes the same event task and confirms it is no longer active.",
+          "The assistant then deletes the same event task and confirms it no longer exists.",
         ],
         fail: [
           "Do not create a replacement event task.",
@@ -272,7 +272,6 @@ describeEval("Event Task Management", slackEvals, (it) => {
           tasks: [
             expect.objectContaining({
               id: "evt_issue_state_summary",
-              status: "active",
               triggerAvailable: true,
             }),
           ],
@@ -346,7 +345,6 @@ describeEval("Event Task Management", slackEvals, (it) => {
           tasks: [
             expect.objectContaining({
               id: "evt_unavailable_issue_summary",
-              status: "active",
               triggerAvailable: false,
             }),
           ],

packages/junior/src/chat/event-tasks/store.ts

@@ -71,7 +71,7 @@ export async function deleteEventTask(
   return rows[0] ? parseTask(rows[0].task) : undefined;
 }
 
-/** List active event tasks in one Slack workspace. */
+/** List event tasks in one Slack workspace. */
 export async function listEventTasksForTeam(
   db: JuniorDatabase,
   teamId: string,
@@ -84,7 +84,7 @@ export async function listEventTasksForTeam(
   return rows.map((row) => parseTask(row.task));
 }
 
-/** Find every active task matching one normalized resource event. */
+/** Find every task matching one normalized resource event. */
 export async function findMatchingEventTasks(
   db: JuniorDatabase,
   event: ResourceEvent,

packages/junior/src/chat/event-tasks/tool-support.ts

@@ -23,7 +23,6 @@ export const MAX_LISTED_EVENT_TASKS = 50;
 const compactEventTaskResultSchema = z
   .object({
     id: z.string().min(1),
-    status: z.enum(["active", "deleted"]),
     task: z.string().min(1),
     namespace: z.string().min(1),
     identifier: z.string().min(1),
@@ -148,7 +147,7 @@ export function eventTaskMatchesDestination(
   );
 }
 
-/** Load one active task only when it belongs to this Slack channel or DM. */
+/** Load one task only when it belongs to this Slack channel or DM. */
 export async function writableEventTask(
   context: ToolRuntimeContext,
   id: string,
@@ -222,11 +221,9 @@ function triggerAvailable(
 export function compactEventTask(
   task: EventTask,
   catalog: ResourceEventCatalog,
-  status: "active" | "deleted" = "active",
 ) {
   return compactEventTaskResultSchema.parse({
     id: task.id,
-    status,
     task: task.task.text,
     namespace: task.trigger.namespace,
     identifier: task.trigger.identifier,
@@ -243,9 +240,8 @@ export function compactEventTask(
 export function eventTaskSuccess(
   task: EventTask,
   catalog: ResourceEventCatalog,
-  status: "active" | "deleted" = "active",
 ) {
-  const details = { task: compactEventTask(task, catalog, status) };
+  const details = { task: compactEventTask(task, catalog) };
   return {
     ok: true as const,
     status: "success" as const,

packages/junior/src/chat/tools/create-event-task.ts

@@ -36,7 +36,7 @@ export function createEventTaskTool(
     },
     executionMode: "sequential",
     description:
-      "Create a durable event task that executes the supplied instruction for every matching resource event. Use for whenever-this-happens-do-X automation; ordinary watch, notify, or tell-me-when requests use watchResourceEvents instead. The task remains active for this Slack channel or DM until deleted and may use the creator's connected credentials. Prefer a subscribable tool result when available.",
+      "Create a durable event task that executes the supplied instruction for every matching resource event. Use for whenever-this-happens-do-X automation; ordinary watch, notify, or tell-me-when requests use watchResourceEvents instead. The task remains configured for this Slack channel or DM until deleted and may use the creator's connected credentials. Prefer a subscribable tool result when available.",
     inputSchema: z
       .object({
         task: z.string().trim().min(1).max(4000),

packages/junior/src/chat/tools/delete-event-task.ts

@@ -37,7 +37,7 @@ export function createDeleteEventTaskTool(
           "Event task was not found in this Slack channel or DM.",
         );
       }
-      return eventTaskSuccess(deleted, catalog, "deleted");
+      return eventTaskSuccess(deleted, catalog);
     },
   });
 }

packages/junior/tests/integration/event-tasks.test.ts

@@ -422,12 +422,11 @@ describe("event tasks", () => {
       createListEventTasksTool(context(), {}),
       {},
     )) as {
-      tasks: Array<{ id: string; status: string; triggerAvailable: boolean }>;
+      tasks: Array<{ id: string; triggerAvailable: boolean }>;
     };
     expect(listed.tasks).toEqual([
       expect.objectContaining({
         id: created.task.id,
-        status: "active",
         triggerAvailable: false,
       }),
     ]);