fix(agent): preserve named policy and retention

Author: dcramer

packages/junior/src/chat/agent-invocations/README.md

@@ -7,13 +7,15 @@ stores the terminal result for its parent to read later.
 ## Records
 
 - An **agent binding** maps one name within a parent agent conversation to one
-  destinationless child conversation. Reusing the name reuses that child's
-  history.
+  destinationless child conversation and its reasoning policy. Reusing the
+  name reuses that child's history; an omitted reasoning level inherits the
+  binding, while an explicit mismatch is rejected.
 - An **agent invocation** is one retry-safe task sent to a child. Its
   `invocationId` is derived from the parent conversation and caller-supplied
   idempotency key.
 - An invocation without a name gets an invocation-scoped child conversation.
-- Child conversation lineage is immutable. Recursive delegation is disabled
+- Child conversation lineage is immutable. Bindings and invocation content are
+  purged with their root conversation tree. Recursive delegation is disabled
   until depth, cancellation, and authority rules are defined.
 
 SQL owns bindings, invocation status, bounded execution authority, and terminal

packages/junior/src/chat/agent-invocations/store.ts

@@ -223,9 +223,27 @@ export async function createAgentInvocation(
     input.agentName ? childConversationId : invocationId
   }`;
   return await getSqlExecutor().withLock(lockName, async () => {
+    const existingBinding = input.agentName
+      ? await getAgentBinding({
+          name: input.agentName,
+          parentConversationId: input.parentConversationId,
+        })
+      : undefined;
+    if (
+      existingBinding &&
+      input.reasoningLevel !== undefined &&
+      input.reasoningLevel !== existingBinding.reasoningLevel
+    ) {
+      throw new Error(
+        `Named agent binding policy changed for ${input.agentName}`,
+      );
+    }
+    const effectiveInput = existingBinding?.reasoningLevel
+      ? { ...input, reasoningLevel: existingBinding.reasoningLevel }
+      : input;
     const existing = await getAgentInvocation(invocationId);
     if (existing) {
-      if (!sameCreateInput(existing, input)) {
+      if (!sameCreateInput(existing, effectiveInput)) {
         throw new Error(
           `Agent invocation idempotency key was reused with different input for ${invocationId}`,
         );
@@ -249,7 +267,7 @@ export async function createAgentInvocation(
           createdAt: new Date(nowMs),
           name: input.agentName,
           parentConversationId: input.parentConversationId,
-          reasoningLevel: input.reasoningLevel ?? null,
+          reasoningLevel: effectiveInput.reasoningLevel ?? null,
           updatedAt: new Date(nowMs),
         })
         .onConflictDoNothing();
@@ -262,7 +280,7 @@ export async function createAgentInvocation(
           `Named agent binding did not resolve to ${childConversationId}`,
         );
       }
-      if (binding.reasoningLevel !== input.reasoningLevel) {
+      if (binding.reasoningLevel !== effectiveInput.reasoningLevel) {
         throw new Error(
           `Named agent binding policy changed for ${input.agentName}`,
         );
@@ -283,13 +301,13 @@ export async function createAgentInvocation(
         parentConversationId: input.parentConversationId,
         childConversationId,
         agentName: input.agentName ?? null,
-        input: input.input,
-        actor: input.actor,
-        credentialContext: input.credentialContext ?? null,
-        source: input.source,
-        destination: input.destination,
-        destinationVisibility: input.destinationVisibility ?? null,
-        reasoningLevel: input.reasoningLevel ?? null,
+        input: effectiveInput.input,
+        actor: effectiveInput.actor,
+        credentialContext: effectiveInput.credentialContext ?? null,
+        source: effectiveInput.source,
+        destination: effectiveInput.destination,
+        destinationVisibility: effectiveInput.destinationVisibility ?? null,
+        reasoningLevel: effectiveInput.reasoningLevel ?? null,
         status: "pending",
         mailboxStatus: "pending",
         createdAt: new Date(nowMs),
@@ -298,7 +316,7 @@ export async function createAgentInvocation(
       })
       .onConflictDoNothing();
     const invocation = await getAgentInvocation(invocationId);
-    if (!invocation || !sameCreateInput(invocation, input)) {
+    if (!invocation || !sameCreateInput(invocation, effectiveInput)) {
       throw new Error(`Agent invocation creation raced for ${invocationId}`);
     }
     return { invocation, status: "created" };

packages/junior/src/chat/conversations/sql/purge.ts

@@ -5,6 +5,7 @@ import {
   juniorConversationEvents,
   juniorConversations,
   juniorDestinations,
+  juniorAgentBindings,
   juniorAgentInvocations,
 } from "@/db/schema";
 import { withConversationEventLock } from "./event-lock";
@@ -111,6 +112,11 @@ export async function selectExpiredRoots(
         where invocations.parent_conversation_id = tree.conversation_id
            or invocations.child_conversation_id = tree.conversation_id
       )
+      or exists (
+        select 1 from junior_agent_bindings bindings
+        where bindings.parent_conversation_id = tree.conversation_id
+           or bindings.child_conversation_id = tree.conversation_id
+      )
       or (
         ${juniorDestinations.visibility} is distinct from 'public'
         and exists (
@@ -274,6 +280,15 @@ export async function purgeConversationTree(
                 inArray(juniorAgentInvocations.childConversationId, ids),
               ),
             );
+          await executor
+            .db()
+            .delete(juniorAgentBindings)
+            .where(
+              or(
+                inArray(juniorAgentBindings.parentConversationId, ids),
+                inArray(juniorAgentBindings.childConversationId, ids),
+              ),
+            );
           await executor
             .db()
             .update(juniorConversations)

packages/junior/tests/component/conversations/retention.test.ts

@@ -14,6 +14,7 @@ import {
   juniorConversationEvents,
   juniorConversations,
   juniorDestinations,
+  juniorAgentBindings,
   juniorAgentInvocations,
 } from "@/db/schema";
 import type { JuniorDestinationVisibility } from "@/db/schema/destinations";
@@ -411,6 +412,56 @@ describe("retention purge job", () => {
     expect(await eventCount(fixture.sql, "remaining-child")).toBe(0);
   });
 
+  it("selects and purges a tree whose remaining content is only an agent binding", async () => {
+    const dest = await seedDestination(fixture.sql, "private");
+    await seedConversation(fixture.sql, {
+      conversationId: "binding-root",
+      destinationId: dest,
+      lastActivityAtMs: BASE_MS,
+      title: null,
+      channelName: null,
+      withContent: false,
+    });
+    await fixture.sql
+      .db()
+      .update(juniorConversations)
+      .set({ actor: null })
+      .where(eq(juniorConversations.conversationId, "binding-root"));
+    await seedConversation(fixture.sql, {
+      conversationId: "binding-child",
+      parentConversationId: "binding-root",
+      lastActivityAtMs: BASE_MS,
+      title: null,
+      channelName: null,
+      withContent: false,
+    });
+    await fixture.sql
+      .db()
+      .update(juniorConversations)
+      .set({ actor: null })
+      .where(eq(juniorConversations.conversationId, "binding-child"));
+    await fixture.sql
+      .db()
+      .insert(juniorAgentBindings)
+      .values({
+        childConversationId: "binding-child",
+        createdAt: new Date(BASE_MS),
+        name: "retained-name",
+        parentConversationId: "binding-root",
+        reasoningLevel: "high",
+        updatedAt: new Date(BASE_MS),
+      });
+
+    const result = await runRetentionPurge(fixture.sql, {
+      nowMs: BASE_MS + 30 * DAY_MS,
+    });
+
+    expect(result.purged).toBe(1);
+    await expect(
+      fixture.sql.db().select().from(juniorAgentBindings),
+    ).resolves.toEqual([]);
+  });
+
   it("purges up to the batch limit and leaves the remainder for the next run", async () => {
     const dest = await seedDestination(fixture.sql, "private");
     await seedConversation(fixture.sql, {

packages/junior/tests/integration/agent-invocation-concurrency.test.ts

@@ -221,6 +221,7 @@ describe("agent invocation identity and concurrency", () => {
         agentName: "researcher",
         idempotencyKey: "named-1",
         input: "first named task",
+        reasoningLevel: "high",
       });
       await harness.drainQueuedWork();
       const second = await harness.spawn({
@@ -235,6 +236,8 @@ describe("agent invocation identity and concurrency", () => {
       );
       expect(requests).toHaveLength(2);
       expect(requests[0]?.input.piMessages).toEqual([]);
+      expect(requests[0]?.policy?.reasoningLevel).toBe("high");
+      expect(requests[1]?.policy?.reasoningLevel).toBe("high");
       expect(requests[1]?.input.piMessages).toEqual(
         expect.arrayContaining([
           expect.objectContaining({ role: "user" }),
@@ -247,6 +250,7 @@ describe("agent invocation identity and concurrency", () => {
       await expect(
         getAgentInvocation(second.invocation.invocationId),
       ).resolves.toMatchObject({
+        reasoningLevel: "high",
         result: "result:second named task",
         status: "completed",
       });

packages/junior/tests/integration/agent-invocation-work.test.ts

@@ -163,6 +163,14 @@ describe("agent invocation conversation work", () => {
           agentName: "researcher",
         }),
       ).rejects.toThrow("idempotency key was reused with different input");
+      await expect(
+        createAgentInvocation({
+          ...invocationInput,
+          agentName: "researcher",
+          idempotencyKey: "named-policy-change",
+          reasoningLevel: "high",
+        }),
+      ).rejects.toThrow("Named agent binding policy changed for researcher");
       await expect(
         createAgentInvocation({
           ...invocationInput,