fix(github-issues): ban conventional commit prefixes in issue titles#739
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
force-pushed
the
fix/no-conventional-commit-in-issue-titles
branch
from
4be696b to
9a48ab1
Compare
Issue titles were being created with fix(x):, feat(x):, ref(x): etc. These formats belong in commit messages and PR titles, not GitHub issues. Added explicit hard constraint in SKILL.md and anti-pattern in issue-examples.md to prevent this. Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
dcramer
force-pushed
the
fix/no-conventional-commit-in-issue-titles
branch
from
9a48ab1 to
0eb615d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
Junior was creating GitHub issues with conventional commit-style prefixes in their titles —
fix(attachments): ...,feat(sandbox): ...,ref(task-execution): ...— which is wrong. That format belongs in commit messages and PR titles only.Evidence
Several real issues in
getsentry/juniorwith the wrong format:fix(attachments): durable file attachment pipeline…feat: first-class agents.toml / dotagents skill supportfeat(sandbox): make snapshot sandbox vcpus/memory configurable via env varref(task-execution): centralize wake scheduling with ensureConversationWake()feat(memory): add recall-layer relevance gate to filter low-relevance vector matchesRoot cause
The
github-issuesskill had no explicit rule against conventional commit prefixes in issue titles. Thepr-writerskill heavily usesfix(scope):for PR titles, and without a constraint in the issue skill the model generalizes the pattern to issues too.Fix
Added a single prescriptive hard constraint to
SKILL.md§ Draft issue content:Verification
Content review — no automated checks applicable for skill text changes.