From 45ed4cca909336482209f3a8984c33a58eb8932a Mon Sep 17 00:00:00 2001 From: immutable dcramer Date: Thu, 2 Jul 2026 21:14:30 +0000 Subject: [PATCH 1/3] docs(github-code): Add PR lifecycle subscription step after PR creation Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> --- packages/junior-github/skills/github-code/SKILL.md | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/junior-github/skills/github-code/SKILL.md b/packages/junior-github/skills/github-code/SKILL.md index e08e20bce..91101939a 100644 --- a/packages/junior-github/skills/github-code/SKILL.md +++ b/packages/junior-github/skills/github-code/SKILL.md @@ -132,7 +132,19 @@ Defaults: **Assignment:** resolve GitHub handles from evidence (`gh api search/users`, org membership, repo history) before assigning requested reviewers or assignees. Skip assignment when the handle cannot be confirmed. -### 7. Report result +### 7. Subscribe to PR lifecycle + +After `github_createPullRequest` succeeds, check whether the result includes a subscribable resource hint. If it does, call `subscribeToResourceEvents` immediately before reporting. + +- Use the suggested events from the hint; when absent, request review and CI events. +- Write a **self-contained intent** that captures: repo, PR number, branch, and what to do when each event class fires: + - **Review feedback** (changes requested, or new review comments): load `pr-cleanup`, address all validated feedback, push, and report. + - **CI failure** (check suite failed on the PR branch): load `pr-cleanup`, read the failed logs, trace the root cause, fix, push, and report. + - **CI green** (all checks pass after a prior failure): confirm the PR is unblocked and summarize the current state. + +If no subscribable hint is present, skip this step. + +### 8. Report result Return: repo, branch, PR URL/number (when applicable), checks run with results, pre-existing failures if any, checks not run and why. From 6b9d1fe1f9969414daf4806eb7048833177584ce Mon Sep 17 00:00:00 2001 From: immutable dcramer Date: Thu, 2 Jul 2026 21:15:36 +0000 Subject: [PATCH 2/3] docs(github-code): Simplify PR lifecycle subscription intent Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> --- packages/junior-github/skills/github-code/SKILL.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/junior-github/skills/github-code/SKILL.md b/packages/junior-github/skills/github-code/SKILL.md index 91101939a..327a01957 100644 --- a/packages/junior-github/skills/github-code/SKILL.md +++ b/packages/junior-github/skills/github-code/SKILL.md @@ -137,10 +137,7 @@ Defaults: After `github_createPullRequest` succeeds, check whether the result includes a subscribable resource hint. If it does, call `subscribeToResourceEvents` immediately before reporting. - Use the suggested events from the hint; when absent, request review and CI events. -- Write a **self-contained intent** that captures: repo, PR number, branch, and what to do when each event class fires: - - **Review feedback** (changes requested, or new review comments): load `pr-cleanup`, address all validated feedback, push, and report. - - **CI failure** (check suite failed on the PR branch): load `pr-cleanup`, read the failed logs, trace the root cause, fix, push, and report. - - **CI green** (all checks pass after a prior failure): confirm the PR is unblocked and summarize the current state. +- Write a **self-contained intent** that captures repo, PR number, branch, and a single goal: resolve any review concerns and keep the build green. When an event fires, read the signal, address it, push, and report. If no subscribable hint is present, skip this step. From 57f7ecbcdf0912d0288d38828ce91f9934aa6d9e Mon Sep 17 00:00:00 2001 From: immutable dcramer Date: Thu, 2 Jul 2026 21:17:32 +0000 Subject: [PATCH 3/3] docs(github-code): Only post PR lifecycle updates when there is something meaningful to say Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> --- packages/junior-github/skills/github-code/SKILL.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/junior-github/skills/github-code/SKILL.md b/packages/junior-github/skills/github-code/SKILL.md index 327a01957..9412d1548 100644 --- a/packages/junior-github/skills/github-code/SKILL.md +++ b/packages/junior-github/skills/github-code/SKILL.md @@ -138,6 +138,7 @@ After `github_createPullRequest` succeeds, check whether the result includes a s - Use the suggested events from the hint; when absent, request review and CI events. - Write a **self-contained intent** that captures repo, PR number, branch, and a single goal: resolve any review concerns and keep the build green. When an event fires, read the signal, address it, push, and report. +- **Only post an update when there is something meaningful to say.** Report when feedback has been addressed, a build failure has been fixed, the PR is fully green and ready to merge, or the PR has been merged. Stay silent on intermediate CI passes, queued checks, and informational events with no action taken. If no subscribable hint is present, skip this step.