fix(slack): Stop sending synthetic resource-event timestamps#741
Merged
Conversation
Prevent synthetic resource-event mailbox ids from being treated as native Slack message timestamps. Resource-event notifications no longer serialize raw.ts, Slack message-targeting APIs require a schema-branded SlackMessageTs, and durable helpers only use explicit persisted slackTs context. Update the Slack/resource-event contracts and regression coverage so processing reactions stay off synthetic notifications while historical malformed raw.ts payloads remain ignored. Fixes JUNIOR-3B Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent synthetic resource-event mailbox ids from crossing into Slack message-targeting APIs.
Resource-event notifications now serialize without a native Slack raw.ts, and Slack reaction/delete/resume/tool paths require a schema-branded SlackMessageTs parsed from native Slack timestamp fields. Durable resume and vision helpers now use explicit persisted meta.slackTs rather than inferring provider context from message ids.
This also updates the Slack/resource-event contracts so synthetic notifications are documented as mailbox context rather than native Slack messages, and adds regression coverage for historical malformed raw.ts payloads plus serializer output.
Found while investigating production Slack reactions.add message_not_found errors.
Fixes JUNIOR-3B