fix(cli): Align init scaffold with example Nitro app#749
Merged
Conversation
Generate new Junior apps with the direct Nitro CLI shape used by the example app, including explicit plugin wiring, current Nitro-related dependencies, and TypeScript config. Drop the stale Vite scaffold and top-level Vercel API queue source so the generated app follows juniorNitro() deployment wiring. Add parity coverage against apps/example for core scaffold scripts, dependencies, deployment config, server wiring, Nitro config, and TypeScript config so future example changes trip a deterministic test. Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
junior initnow emits the same core Nitro app shape thatapps/exampleexercises: directnitro dev/nitro buildscripts, explicitplugins.tswiring intocreateApp({ plugins }), current Nitro-related dependency versions, andtsconfig.json. It no longer generates the stale Vite scaffold or top-level/api/internal/agent/continue.tssource, and the generated env/CI templates include the database variables and install flow a fresh app actually needs.The init unit test now uses
apps/exampleas a canary for core scripts, dependencies,vercel.json, Nitro config, server wiring, and TypeScript config so future drift fails deterministically. The setup docs and README snippets now match that generated shape.Validation:
pnpm --filter @sentry/junior exec vitest run tests/unit/cli/init-cli.test.tspnpm docs:check