fix(artifacts): Remove iOS distribution skip reporting (EME-422)

Revert the iOS-specific changes that reported skip reasons for invalid
code signatures and simulator builds. Keep the unsupported artifact
type error reporting via the distribution endpoint.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: runningcode

src/launchpad/artifact_processor.py

@@ -308,20 +308,13 @@ def _do_distribution(
         logger.info(f"BUILD_DISTRIBUTION for {artifact_id} (project: {project_id}, org: {organization_id})")
         if isinstance(artifact, ZippedXCArchive):
             apple_info = cast(AppleAppInfo, info)
-            if not apple_info.is_code_signature_valid:
-                logger.warning(f"BUILD_DISTRIBUTION skipped for {artifact_id}: invalid code signature")
-                self._update_distribution_skip(organization_id, project_id, artifact_id, "invalid_signature")
-                return
-            if apple_info.is_simulator:
-                logger.warning(f"BUILD_DISTRIBUTION skipped for {artifact_id}: simulator build")
-                self._update_distribution_skip(organization_id, project_id, artifact_id, "simulator")
-                return
-            with tempfile.TemporaryDirectory() as temp_dir_str:
-                temp_dir = Path(temp_dir_str)
-                ipa_path = temp_dir / "App.ipa"
-                artifact.generate_ipa(ipa_path)
-                with open(ipa_path, "rb") as f:
-                    self._sentry_client.upload_installable_app(organization_id, project_id, artifact_id, f)
+            if apple_info.is_code_signature_valid and not apple_info.is_simulator:
+                with tempfile.TemporaryDirectory() as temp_dir_str:
+                    temp_dir = Path(temp_dir_str)
+                    ipa_path = temp_dir / "App.ipa"
+                    artifact.generate_ipa(ipa_path)
+                    with open(ipa_path, "rb") as f:
+                        self._sentry_client.upload_installable_app(organization_id, project_id, artifact_id, f)
         elif isinstance(artifact, (AAB, ZippedAAB)):
             with tempfile.TemporaryDirectory() as temp_dir_str:
                 temp_dir = Path(temp_dir_str)
@@ -430,24 +423,6 @@ def _update_artifact_error(
         else:
             logger.info(f"Successfully updated artifact {artifact_id} with error information")
 
-    def _update_distribution_skip(
-        self,
-        organization_id: str,
-        project_id: str,
-        artifact_id: str,
-        skip_reason: str,
-    ) -> None:
-        """Report distribution skip via the dedicated distribution endpoint."""
-        try:
-            self._sentry_client.update_distribution_error(
-                org=organization_id,
-                artifact_id=artifact_id,
-                error_code=InstallableAppErrorCode.SKIPPED.value,
-                error_message=skip_reason,
-            )
-        except Exception:
-            logger.exception(f"Failed to update distribution skip for artifact {artifact_id}")
-
     def _update_size_error_from_exception(
         self,
         organization_id: str,

tests/unit/artifacts/test_artifact_processor.py

@@ -6,7 +6,6 @@
 )
 
 from launchpad.artifact_processor import ArtifactProcessor
-from launchpad.artifacts.apple.zipped_xcarchive import ZippedXCArchive
 from launchpad.artifacts.artifact import Artifact
 from launchpad.constants import (
     InstallableAppErrorCode,
@@ -159,46 +158,6 @@ def test_do_distribution_unknown_artifact_type_reports_error(self):
             error_message="unsupported artifact type",
         )
 
-    def test_do_distribution_invalid_code_signature_skips(self):
-        mock_sentry_client = Mock(spec=SentryClient)
-        mock_sentry_client.update_distribution_error.return_value = None
-        self.processor._sentry_client = mock_sentry_client
-
-        artifact = Mock(spec=ZippedXCArchive)
-        mock_info = Mock()
-        mock_info.is_code_signature_valid = False
-        mock_info.is_simulator = False
-
-        self.processor._do_distribution("test-org-id", "test-project-id", "test-artifact-id", artifact, mock_info)
-
-        mock_sentry_client.update_distribution_error.assert_called_once_with(
-            org="test-org-id",
-            artifact_id="test-artifact-id",
-            error_code=InstallableAppErrorCode.SKIPPED.value,
-            error_message="invalid_signature",
-        )
-        mock_sentry_client.upload_installable_app.assert_not_called()
-
-    def test_do_distribution_simulator_build_skips(self):
-        mock_sentry_client = Mock(spec=SentryClient)
-        mock_sentry_client.update_distribution_error.return_value = None
-        self.processor._sentry_client = mock_sentry_client
-
-        artifact = Mock(spec=ZippedXCArchive)
-        mock_info = Mock()
-        mock_info.is_code_signature_valid = True
-        mock_info.is_simulator = True
-
-        self.processor._do_distribution("test-org-id", "test-project-id", "test-artifact-id", artifact, mock_info)
-
-        mock_sentry_client.update_distribution_error.assert_called_once_with(
-            org="test-org-id",
-            artifact_id="test-artifact-id",
-            error_code=InstallableAppErrorCode.SKIPPED.value,
-            error_message="simulator",
-        )
-        mock_sentry_client.upload_installable_app.assert_not_called()
-
 
 class TestArtifactProcessorMessageHandling:
     """Test message processing functionality in ArtifactProcessor."""