Skip to content

Commit 4ef03e1

Browse files
runningcodeclaude
andcommitted
fix(artifacts): Widen exception handling for distribution notifications (EME-422)
Catch all exceptions (not just SentryClientError) when reporting distribution errors/skips. Network errors like ConnectionError and Timeout from requests aren't subclasses of SentryClientError, so they would propagate uncaught and crash the pipeline. These are best-effort notifications that should never block artifact processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 1905724 commit 4ef03e1

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/launchpad/artifact_processor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ def _do_distribution(
347347
error_code=InstallableAppErrorCode.PROCESSING_ERROR.value,
348348
error_message="unsupported artifact type",
349349
)
350-
except SentryClientError:
350+
except Exception:
351351
logger.exception(f"Failed to update distribution error for artifact {artifact_id}")
352352

353353
def _do_size(
@@ -445,7 +445,7 @@ def _update_distribution_skip(
445445
error_code=InstallableAppErrorCode.SKIPPED.value,
446446
error_message=skip_reason,
447447
)
448-
except SentryClientError:
448+
except Exception:
449449
logger.exception(f"Failed to update distribution skip for artifact {artifact_id}")
450450

451451
def _update_size_error_from_exception(

0 commit comments

Comments
 (0)