fix(artifacts): Report error for iOS distribution failures (EME-422)

When a ZippedXCArchive has an invalid code signature or is a simulator
build, _do_distribution now reports the specific error via
_update_artifact_error instead of silently doing nothing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: runningcode

src/launchpad/artifact_processor.py

@@ -302,13 +302,32 @@ def _do_distribution(
         logger.info(f"BUILD_DISTRIBUTION for {artifact_id} (project: {project_id}, org: {organization_id})")
         if isinstance(artifact, ZippedXCArchive):
             apple_info = cast(AppleAppInfo, info)
-            if apple_info.is_code_signature_valid and not apple_info.is_simulator:
-                with tempfile.TemporaryDirectory() as temp_dir_str:
-                    temp_dir = Path(temp_dir_str)
-                    ipa_path = temp_dir / "App.ipa"
-                    artifact.generate_ipa(ipa_path)
-                    with open(ipa_path, "rb") as f:
-                        self._sentry_client.upload_installable_app(organization_id, project_id, artifact_id, f)
+            if not apple_info.is_code_signature_valid:
+                logger.warning(f"BUILD_DISTRIBUTION skipped for {artifact_id}: invalid code signature")
+                self._update_artifact_error(
+                    organization_id,
+                    project_id,
+                    artifact_id,
+                    ProcessingErrorCode.ARTIFACT_PROCESSING_ERROR,
+                    ProcessingErrorMessage.INVALID_CODE_SIGNATURE,
+                )
+                return
+            if apple_info.is_simulator:
+                logger.warning(f"BUILD_DISTRIBUTION skipped for {artifact_id}: simulator build")
+                self._update_artifact_error(
+                    organization_id,
+                    project_id,
+                    artifact_id,
+                    ProcessingErrorCode.ARTIFACT_PROCESSING_ERROR,
+                    ProcessingErrorMessage.SIMULATOR_BUILD,
+                )
+                return
+            with tempfile.TemporaryDirectory() as temp_dir_str:
+                temp_dir = Path(temp_dir_str)
+                ipa_path = temp_dir / "App.ipa"
+                artifact.generate_ipa(ipa_path)
+                with open(ipa_path, "rb") as f:
+                    self._sentry_client.upload_installable_app(organization_id, project_id, artifact_id, f)
         elif isinstance(artifact, (AAB, ZippedAAB)):
             with tempfile.TemporaryDirectory() as temp_dir_str:
                 temp_dir = Path(temp_dir_str)

src/launchpad/constants.py

@@ -49,6 +49,8 @@ class ProcessingErrorMessage(Enum):
     SIZE_ANALYSIS_FAILED = "Failed to perform size analysis"
     ARTIFACT_PARSING_FAILED = "Failed to parse artifact file"
     UNSUPPORTED_ARTIFACT_TYPE = "Unsupported artifact type"
+    INVALID_CODE_SIGNATURE = "Cannot distribute app with invalid code signature"
+    SIMULATOR_BUILD = "Cannot distribute simulator builds"
 
     # System-related errors
     TEMP_FILE_CREATION_FAILED = "Failed to create temporary file"

tests/unit/artifacts/test_artifact_processor.py

@@ -6,6 +6,7 @@
 )
 
 from launchpad.artifact_processor import ArtifactProcessor
+from launchpad.artifacts.apple.zipped_xcarchive import ZippedXCArchive
 from launchpad.artifacts.artifact import Artifact
 from launchpad.constants import (
     ProcessingErrorCode,
@@ -161,6 +162,52 @@ def test_do_distribution_unknown_artifact_type_reports_error(self):
             },
         )
 
+    def test_do_distribution_invalid_code_signature_reports_error(self):
+        mock_sentry_client = Mock(spec=SentryClient)
+        mock_sentry_client.update_artifact.return_value = None
+        self.processor._sentry_client = mock_sentry_client
+
+        artifact = Mock(spec=ZippedXCArchive)
+        mock_info = Mock()
+        mock_info.is_code_signature_valid = False
+        mock_info.is_simulator = False
+
+        self.processor._do_distribution("test-org-id", "test-project-id", "test-artifact-id", artifact, mock_info)
+
+        mock_sentry_client.update_artifact.assert_called_once_with(
+            org="test-org-id",
+            project="test-project-id",
+            artifact_id="test-artifact-id",
+            data={
+                "error_code": ProcessingErrorCode.ARTIFACT_PROCESSING_ERROR.value,
+                "error_message": ProcessingErrorMessage.INVALID_CODE_SIGNATURE.value,
+            },
+        )
+        mock_sentry_client.upload_installable_app.assert_not_called()
+
+    def test_do_distribution_simulator_build_reports_error(self):
+        mock_sentry_client = Mock(spec=SentryClient)
+        mock_sentry_client.update_artifact.return_value = None
+        self.processor._sentry_client = mock_sentry_client
+
+        artifact = Mock(spec=ZippedXCArchive)
+        mock_info = Mock()
+        mock_info.is_code_signature_valid = True
+        mock_info.is_simulator = True
+
+        self.processor._do_distribution("test-org-id", "test-project-id", "test-artifact-id", artifact, mock_info)
+
+        mock_sentry_client.update_artifact.assert_called_once_with(
+            org="test-org-id",
+            project="test-project-id",
+            artifact_id="test-artifact-id",
+            data={
+                "error_code": ProcessingErrorCode.ARTIFACT_PROCESSING_ERROR.value,
+                "error_message": ProcessingErrorMessage.SIMULATOR_BUILD.value,
+            },
+        )
+        mock_sentry_client.upload_installable_app.assert_not_called()
+
 
 class TestArtifactProcessorMessageHandling:
     """Test message processing functionality in ArtifactProcessor."""