Skip to content

feat(launchpad): Update artifact factory logic to cover more cases #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NicoHinderling wants to merge 2 commits into from

add some test cases

1afa006
Select commit
Loading
Failed to load commit list.
Closed

feat(launchpad): Update artifact factory logic to cover more cases #140

add some test cases
1afa006
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 8, 2025 in 1s

71.78% (+0.14%) compared to d4acf88

View this Pull Request on Codecov

71.78% (+0.14%) compared to d4acf88

Details

Codecov Report

Attention: Patch coverage is 87.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (d4acf88) to head (1afa006).

Files with missing lines Patch % Lines
src/launchpad/artifacts/apple/zipped_xcarchive.py 64.28% 1 Missing and 4 partials ⚠️
src/launchpad/artifacts/artifact_factory.py 85.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   71.63%   71.78%   +0.14%     
==========================================
  Files          93       93              
  Lines        7320     7365      +45     
  Branches      860      863       +3     
==========================================
+ Hits         5244     5287      +43     
  Misses       1724     1724              
- Partials      352      354       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov