Skip to content

ref: Remove unused HEALTHCHECK_MAX_AGE_SECONDS constant#638

Merged
NicoHinderling merged 1 commit into
mainfrom
nico/ref/remove-dead-healthcheck-constant
Jun 25, 2026
Merged

ref: Remove unused HEALTHCHECK_MAX_AGE_SECONDS constant#638
NicoHinderling merged 1 commit into
mainfrom
nico/ref/remove-dead-healthcheck-constant

Conversation

@NicoHinderling

Copy link
Copy Markdown
Contributor

Summary

HEALTHCHECK_MAX_AGE_SECONDS is a leftover from the Kafka-era file-touch healthcheck. It has been unreferenced anywhere in the codebase since the HTTP server was removed during the TaskBroker migration.

The worker's health check is now handled by TaskBroker via the health_check_file_path mechanism (/tmp/health), so this constant serves no purpose.

Context

Companion cleanup to the ops-repo removal of launchpad's dead HTTP ingress (getsentry/ops#21502). This is the launchpad-side dead-config counterpart.

Verification

  • grep confirms the only occurrence was the definition itself.
  • make check passes (lint, format, types, deps).

Leftover from the Kafka-era file-touch healthcheck. The constant has
been unreferenced since the HTTP server was removed in the TaskBroker
migration; the worker's health check is now handled by TaskBroker via
the health_check_file_path mechanism.
@sentry

sentry Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
HackerNews com.emergetools.hackernews 3.8 (1) Release

Android

🔗 App Name App ID Version Configuration
Hacker News com.emergetools.hackernews 1.0.2 (13) Release

⚙️ launchpad-test-android Build Distribution Settings

@NicoHinderling NicoHinderling merged commit 28adddd into main Jun 25, 2026
23 checks passed
@NicoHinderling NicoHinderling deleted the nico/ref/remove-dead-healthcheck-constant branch June 25, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants