-
-
Notifications
You must be signed in to change notification settings - Fork 5
Expand file tree
/
Copy pathbatch.rs
More file actions
330 lines (304 loc) · 10.2 KB
/
Copy pathbatch.rs
File metadata and controls
330 lines (304 loc) · 10.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
use std::sync::Arc;
use std::time::SystemTime;
use axum::Router;
use axum::extract::{DefaultBodyLimit, State};
use axum::response::{IntoResponse, Response};
use axum::routing;
use bytes::{Bytes, BytesMut};
use futures::StreamExt;
use futures::TryStreamExt;
use http::header::CONTENT_TYPE;
use http::{HeaderMap, HeaderValue, StatusCode};
use objectstore_service::id::{ObjectContext, ObjectKey};
use objectstore_service::streaming::{OpResponse, Operation};
use percent_encoding::NON_ALPHANUMERIC;
use crate::auth::AuthAwareService;
use crate::batch::{
HEADER_BATCH_OPERATION_INDEX, HEADER_BATCH_OPERATION_KEY, HEADER_BATCH_OPERATION_KIND,
};
use crate::endpoints::common::{ApiError, ApiErrorResponse};
use crate::extractors::Xt;
use crate::extractors::batch::{BatchError, BatchOperationStream};
use crate::multipart::{IntoMultipartResponse, Part};
use crate::state::ServiceState;
const MAX_BODY_SIZE: usize = 1024 * 1024 * 1024; // 1 GB
const HEADER_BATCH_OPERATION_STATUS: &str = "x-sn-batch-operation-status";
pub fn router() -> Router<ServiceState> {
Router::new()
.route("/objects:batch/{usecase}/{scopes}/", routing::post(batch))
// Enforced by https://github.com/tokio-rs/axum/blob/4404f27cea206b0dca63637b1c76dff23772a5cc/axum/src/extract/multipart.rs#L78
.layer(DefaultBodyLimit::max(MAX_BODY_SIZE))
}
/// Applies a per-operation check to a stream of indexed operations.
///
/// Errors already in the stream pass through unchanged. For each `Ok(op)`,
/// `check` is called: if it returns `Err(e)` the item becomes `Err(e)`;
/// otherwise the item remains `Ok(op)`.
fn validate<S, E, F>(
stream: S,
check: F,
) -> impl futures::Stream<Item = (usize, Result<Operation, E>)> + Send + 'static
where
S: futures::Stream<Item = (usize, Result<Operation, E>)> + Send + 'static,
F: Fn(&Operation) -> Result<(), E> + Send + 'static,
{
stream.map(move |(idx, item)| {
(
idx,
item.and_then(|op| {
check(&op)?;
Ok(op)
}),
)
})
}
async fn batch(
service: AuthAwareService,
State(state): State<ServiceState>,
Xt(context): Xt<ObjectContext>,
requests: BatchOperationStream,
) -> Response {
let batch = match state.service.stream() {
Ok(b) => b,
Err(e) => return ApiError::Service(e).into_response(),
};
objectstore_metrics::gauge!("service.batch.window" = batch.window());
// Step 1: parse multipart fields → (idx, Result<Operation, ApiError>)
let parsed = requests.0.map(|r| r.map_err(ApiError::from)).enumerate();
// Step 2: rate-limit check
let rate_limited = validate(parsed, {
let state = Arc::clone(&state);
let context = context.clone();
move |_op| {
if state.rate_limiter.check(&context) {
Ok(())
} else {
Err(ApiError::from(BatchError::RateLimited))
}
}
});
// Step 3: auth check
let authorized = validate(rate_limited, {
let context = context.clone();
move |op| service.check_permission(op.permission(), &context)
});
// Step 4: use case policy validation
let policy_checked = validate(authorized, {
let state = Arc::clone(&state);
let usecase = context.usecase.clone();
move |op| {
if let Operation::Insert(ins) = op {
state
.config
.usecases
.validate(&usecase, &ins.metadata)
.map_err(|e| ApiError::Client(e.to_string()))?;
}
Ok(())
}
});
// Step 5: stamp inserts with time_created and record bandwidth
let stamped = policy_checked.map({
let state = Arc::clone(&state);
let context = context.clone();
move |(idx, mut item)| {
if let Ok(Operation::Insert(ins)) = &mut item {
ins.metadata.time_created = Some(SystemTime::now());
state.record_bandwidth(&context, ins.payload.len() as u64);
}
(idx, item)
}
});
// Step 6: execute concurrently, then convert each result to a multipart Part
let state_ref = Arc::clone(&state);
let context_ref = context.clone();
let responses = batch.execute(context, stamped).then(move |(idx, result)| {
let state = Arc::clone(&state_ref);
let context = context_ref.clone();
async move { convert_to_part(idx, result, &state, &context).await }
});
responses.into_multipart_response(rand::random())
}
/// Converts a single operation result to a multipart [`Part`].
///
/// For get operations this collects the payload stream and applies bandwidth metering.
/// The `x-sn-batch-operation-index` header is set on every part.
async fn convert_to_part(
idx: usize,
result: Result<OpResponse, ApiError>,
state: &crate::state::Services,
context: &ObjectContext,
) -> Part {
match result {
Ok(OpResponse::Got {
key,
response: Some((metadata, _content_range, stream)),
}) => got_to_part(idx, key, metadata, stream, state, context)
.await
.unwrap_or_else(|e| create_error_part(idx, &e)),
Ok(OpResponse::Got {
key,
response: None,
}) => create_success_part(
idx,
&key,
"get",
StatusCode::NOT_FOUND,
None,
Bytes::new(),
None,
),
Ok(OpResponse::Inserted { id }) => create_success_part(
idx,
&id.key,
"insert",
// XXX: this could actually be either StatusCode::OK or StatusCode::CREATED, the service
// layer doesn't allow us to distinguish between them currently
StatusCode::CREATED,
None,
Bytes::new(),
None,
),
Ok(OpResponse::Deleted { key }) => create_success_part(
idx,
&key,
"delete",
StatusCode::NO_CONTENT,
None,
Bytes::new(),
None,
),
Ok(OpResponse::Head {
key,
metadata: Some(metadata),
}) => {
let metadata_headers = metadata.to_headers("").map_err(|err| {
ApiError::from(BatchError::ResponseSerialization {
context: "serializing object metadata".to_owned(),
cause: Box::new(err),
})
});
match metadata_headers {
Ok(headers) => create_success_part(
idx,
&key,
"head",
StatusCode::NO_CONTENT,
None,
Bytes::new(),
Some(headers),
),
Err(e) => create_error_part(idx, &e),
}
}
Ok(OpResponse::Head {
key,
metadata: None,
}) => create_success_part(
idx,
&key,
"head",
StatusCode::NOT_FOUND,
None,
Bytes::new(),
None,
),
Err(error) => create_error_part(idx, &error),
}
}
async fn got_to_part(
idx: usize,
key: ObjectKey,
metadata: objectstore_types::metadata::Metadata,
stream: objectstore_service::PayloadStream,
state: &crate::state::Services,
context: &ObjectContext,
) -> Result<Part, ApiError> {
let bytes = state
.meter_stream(stream, context)
.try_collect::<BytesMut>()
.await
.map_err(|e| ApiError::Service(e.into()))?
.freeze();
let mut metadata_headers = metadata.to_headers("").map_err(|err| {
ApiError::from(BatchError::ResponseSerialization {
context: "serializing object metadata".to_owned(),
cause: Box::new(err),
})
})?;
let content_type = metadata_headers.remove(CONTENT_TYPE);
Ok(create_success_part(
idx,
&key,
"get",
StatusCode::OK,
content_type,
bytes,
Some(metadata_headers),
))
}
fn insert_index_header(headers: &mut HeaderMap, idx: usize) {
headers.insert(
HEADER_BATCH_OPERATION_INDEX,
idx.to_string()
.parse()
.expect("usize display is always a valid header value"),
);
}
fn insert_key_header(headers: &mut HeaderMap, key: &ObjectKey) {
let encoded = percent_encoding::percent_encode(key.as_bytes(), NON_ALPHANUMERIC).to_string();
headers.insert(
HEADER_BATCH_OPERATION_KEY,
encoded
.parse()
.expect("percent-encoded string is always a valid header value"),
);
}
fn insert_kind_header(headers: &mut HeaderMap, kind: &str) {
headers.insert(
HEADER_BATCH_OPERATION_KIND,
kind.parse()
.expect("operation kind is always a valid header value"),
);
}
fn insert_status_header(headers: &mut HeaderMap, status: StatusCode) {
let status_str = format!(
"{} {}",
status.as_u16(),
status.canonical_reason().unwrap_or("")
)
.trim()
.to_owned();
headers.insert(
HEADER_BATCH_OPERATION_STATUS,
status_str.parse().expect("always a valid header value"),
);
}
fn create_success_part(
idx: usize,
key: &ObjectKey,
kind: &str,
status: StatusCode,
content_type: Option<HeaderValue>,
body: Bytes,
additional_headers: Option<HeaderMap>,
) -> Part {
let mut headers = HeaderMap::new();
insert_index_header(&mut headers, idx);
insert_key_header(&mut headers, key);
insert_kind_header(&mut headers, kind);
insert_status_header(&mut headers, status);
if let Some(additional) = additional_headers {
headers.extend(additional);
}
Part::new(body, headers, content_type)
}
fn create_error_part(idx: usize, error: &ApiError) -> Part {
let mut headers = HeaderMap::new();
insert_index_header(&mut headers, idx);
insert_status_header(&mut headers, error.status());
let error_body = serde_json::to_vec(&ApiErrorResponse::from_error(error))
.inspect_err(|err| objectstore_log::error!(!!err, "Failed to serialize ApiErrorResponse"))
.unwrap_or_default();
Part::new(Bytes::from(error_body), headers, None)
}