fix(options): Gate refresh spawn on successful OnceLock init; remove stale comment

Only spawn the background refresh task when OPTIONS.set() succeeds, so
concurrent callers cannot produce multiple refresh tasks and filesystem
watchers. Also remove a low-value inline comment in killswitches.rs.

Author: jan-auer

objectstore-options/src/lib.rs

@@ -113,11 +113,14 @@ pub struct Killswitch {
 /// Must be called from within a Tokio runtime.
 pub fn init() -> Result<(), Error> {
     if OPTIONS.get().is_none() {
-        // Load an initial snapshot and fail loudly if it can't be loaded. This ensures the application
-        // will not silently run with defaults or fail later when options are accessed.
+        // Load an initial snapshot and fail loudly if it can't be loaded. This ensures the
+        // application will not silently run with defaults or fail later when options are accessed.
         let inner = sentry_options::Options::from_schemas(&[(NAMESPACE, SCHEMA)])?;
-        let _ = OPTIONS.set(ArcSwap::from_pointee(Options::deserialize(&inner)?));
-        tokio::spawn(refresh(inner));
+        let initial = Options::deserialize(&inner)?;
+
+        if OPTIONS.set(ArcSwap::from_pointee(initial)).is_ok() {
+            tokio::spawn(refresh(inner));
+        }
     }
 
     Ok(())

objectstore-server/src/killswitches.rs

@@ -111,7 +111,6 @@ fn matches(
         }
     }
 
-    // Check service pattern if specified
     if let Some(ref pattern) = switch.service {
         // If pattern is specified but no service header present, don't match
         let Some(service_value) = service else {