ci(release): Fix Craft setup - #260
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| force: ${{ inputs.force }} | ||
| merge_target: ${{ inputs.merge_target }} | ||
| path: clients | ||
| secrets: inherit |
There was a problem hiding this comment.
Bug: The release-clients.yml workflow uses secrets: inherit with the getsentry/craft@v2 composite action, which is not supported. The required GITHUB_TOKEN will not be passed.
Severity: CRITICAL
🔍 Detailed Analysis
The release-clients.yml workflow attempts to pass secrets to the getsentry/craft@v2 action using secrets: inherit. However, getsentry/craft@v2 is a composite action, which does not support the secrets: inherit syntax according to GitHub Actions documentation. This syntax is only valid for reusable workflows. As a result, the GITHUB_TOKEN generated in a previous step will not be available to the craft action. This will cause the action to fail when it attempts to perform authenticated operations against the GitHub API, such as creating a release.
💡 Suggested Fix
Remove secrets: inherit. Pass the required GITHUB_TOKEN to the getsentry/craft@v2 action explicitly. This can be done by restoring the env block (env: GITHUB_TOKEN: ${{ steps.token.outputs.token }}) or by passing it as an input parameter if the composite action supports one for the token.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/release-clients.yml#L45
Potential issue: The `release-clients.yml` workflow attempts to pass secrets to the
`getsentry/craft@v2` action using `secrets: inherit`. However, `getsentry/craft@v2` is a
composite action, which does not support the `secrets: inherit` syntax according to
GitHub Actions documentation. This syntax is only valid for reusable workflows. As a
result, the `GITHUB_TOKEN` generated in a previous step will not be available to the
`craft` action. This will cause the action to fail when it attempts to perform
authenticated operations against the GitHub API, such as creating a release.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8466699
1 participant
No description provided.