Skip to content

ci(release): Fix Craft setup #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcian merged 1 commit into from
Jan 12, 2026
Merged

ci(release): Fix Craft setup #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/release-clients.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,9 @@ jobs:

- name: Prepare release
uses: getsentry/craft@v2
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
version: ${{ inputs.version }}
force: ${{ inputs.force }}
merge_target: ${{ inputs.merge_target }}
path: clients
secrets: inherit

@sentry sentry Bot Jan 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The release-clients.yml workflow uses secrets: inherit with the getsentry/craft@v2 composite action, which is not supported. The required GITHUB_TOKEN will not be passed.
Severity: CRITICAL

🔍 Detailed Analysis

The release-clients.yml workflow attempts to pass secrets to the getsentry/craft@v2 action using secrets: inherit. However, getsentry/craft@v2 is a composite action, which does not support the secrets: inherit syntax according to GitHub Actions documentation. This syntax is only valid for reusable workflows. As a result, the GITHUB_TOKEN generated in a previous step will not be available to the craft action. This will cause the action to fail when it attempts to perform authenticated operations against the GitHub API, such as creating a release.

💡 Suggested Fix

Remove secrets: inherit. Pass the required GITHUB_TOKEN to the getsentry/craft@v2 action explicitly. This can be done by restoring the env block (env: GITHUB_TOKEN: ${{ steps.token.outputs.token }}) or by passing it as an input parameter if the composite action supports one for the token.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/release-clients.yml#L45

Potential issue: The `release-clients.yml` workflow attempts to pass secrets to the
`getsentry/craft@v2` action using `secrets: inherit`. However, `getsentry/craft@v2` is a
composite action, which does not support the `secrets: inherit` syntax according to
GitHub Actions documentation. This syntax is only valid for reusable workflows. As a
result, the `GITHUB_TOKEN` generated in a previous step will not be available to the
`craft` action. This will cause the action to fail when it attempts to perform
authenticated operations against the GitHub API, such as creating a release.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8466699