Skip to content

Commit 49494db

Browse files
committed
Update command dump comparison in ci.yml
1 parent 4357923 commit 49494db

1 file changed

Lines changed: 8 additions & 49 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,24 @@ jobs:
3434
python-version: "3.11"
3535
- name: Install dependencies
3636
run: |
37-
cd codecov-cli
3837
python -m pip install --upgrade pip
39-
pip install -r requirements.txt
40-
python -m pip install -e .
38+
python -m pip install -e codecov-cli
39+
python -m pip install -e prevent-cli
4140
- name: Run command_dump
4241
run: |
43-
cd codecov-cli
44-
python command_dump.py
42+
./command_dump.py
4543
- name: Detect changes on commit
4644
run: |
47-
if [ -n "$(git diff codecovcli_commands)" ]; then
45+
if [ -n "$(git diff codecov-cli/codecovcli_commands)" || -n "$(git diff prevent-cli/preventcli_commands)" ]; then
4846
echo "Please run `python command_dump.py` before submitting, or install the hooks"
49-
echo "$(git diff codecovcli_commands)"
47+
echo "$(git diff codecov-cli/codecovcli_commands)"
48+
echo "$(git diff prevent-cli/preventcli_commands)"
5049
exit 1
5150
fi
5251
53-
# todo: dump commands for prevent-cli. Maybe compare prevent and cc?
54-
5552
codecov-startup:
5653
runs-on: ubuntu-latest
57-
#if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'getsentry' }}
54+
if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'getsentry' }}
5855
steps:
5956
- uses: actions/checkout@v4
6057
with:
@@ -104,47 +101,9 @@ jobs:
104101
env:
105102
CODECOV_ENV: test
106103
- name: Dogfooding codecov-cli
107-
#if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'getsentry' }}
104+
if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'getsentry' }}
108105
run: |
109106
codecovcli -v do-upload --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} --plugin pycoverage --flag python${{matrix.python-version}}
110107
codecovcli do-upload --report-type test_results --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} --plugin pycoverage --flag python${{matrix.python-version}}
111108
# todo: dogfood prevent-cli
112109

113-
# todo: I don't think we need this?
114-
# - name: Upload artifacts for test-results-processing
115-
# if: ${{ !cancelled() }}
116-
# uses: actions/upload-artifact@v4
117-
# with:
118-
# name: ${{matrix.os}}-${{matrix.python-version}}junit.xml
119-
# path: ${{matrix.os}}-${{matrix.python-version}}junit.xml
120-
121-
# todo: I don't think we need this either? we're uploading TA three times?
122-
# process-test-results:
123-
# if: ${{ always() }}
124-
# needs: build-test-upload
125-
# runs-on: ubuntu-latest
126-
# steps:
127-
# - uses: actions/checkout@v4
128-
# with:
129-
# submodules: true
130-
# fetch-depth: 2
131-
# - uses: actions/setup-python@v5
132-
# with:
133-
# python-version: "3.12"
134-
# - name: Install dependencies for Dogfooding
135-
# run: |
136-
# python -m pip install --upgrade pip
137-
# pip install -r requirements.txt
138-
# python -m pip install -e .
139-
# pip install -r tests/requirements.txt
140-
# - name: Download all test results
141-
# uses: actions/download-artifact@v4
142-
# with:
143-
# pattern: "*junit.xml"
144-
# path: "test_results"
145-
# merge-multiple: true
146-
#
147-
# - name: Dogfooding codecov-cli
148-
# if: ${{ !cancelled() && github.ref && contains(github.ref, 'pull') }}
149-
# run: |
150-
# codecovcli process-test-results --dir test_results --github-token ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)