fix: workflow permissions

[spalmurray]

Fixes a bunch of errors in https://github.com/getsentry/prevent-cli/security/code-scanning

also tweaks the pre-commit hook to work with new command dump

[codecov]

❌ 10 Tests Failed:

Tests completed	Failed	Passed	Skipped
7070	10	7060	0

View the top 3 failed test(s) by shortest run time

api.temp.calculator.test_calculator::test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

api.temp.calculator.test_calculator::test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

api.temp.calculator.test_calculator::test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[spalmurray]

In a previous commit I made this directly executable. Locally the hook won't run without this change for me. I think my PATH is bad for whatever reason when running this hook. Could probably fix that, but this is easier and shouldn't break for anyone else 🙈

[thomasrockhu-codecov]

You need to change the file to be executable before committing (chmod u+x command_dump.py) I believe

[thomasrockhu-codecov]

hmmm, even with that, it throws an error

--> ./command_dump.py
./command_dump.py: line 1: import: command not found
./command_dump.py: line 4: syntax error near unexpected token `('
./command_dump.py: line 4: `def command_dump(commands):'

I assume because it's not in a python shell

[spalmurray]

command_dump.py has a shebang for python and is already executable - do you have latest main on this repo?

[thomasrockhu-codecov]

strange, getting this error

tomhu@WLRW6YXHR9 [~/src/github/getsentry/prevent-cli] (main *)
--> ./command_dump.py
Dumping codecovcli
Dumping codecovcli create-commit
Dumping codecovcli create-report
Dumping codecovcli do-upload
Dumping codecovcli empty-upload
Dumping codecovcli pr-base-picking
Dumping codecovcli process-test-results
Dumping codecovcli send-notifications
Dumping codecovcli upload-coverage
Dumping codecovcli upload-process
Dumping sentry-prevent-cli
Traceback (most recent call last):
  File "/Users/tomhu/src/github/getsentry/prevent-cli/./command_dump.py", line 35, in <module>
    command_dump(["sentry-prevent-cli"], "prevent-cli/preventcli_commands")
  File "/Users/tomhu/src/github/getsentry/prevent-cli/./command_dump.py", line 7, in command_dump
    command_docs = subprocess.run(
                   ^^^^^^^^^^^^^^^
  File "/Users/tomhu/.pyenv/versions/3.11.5/lib/python3.11/subprocess.py", line 548, in run
    with Popen(*popenargs, **kwargs) as process:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/tomhu/.pyenv/versions/3.11.5/lib/python3.11/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Users/tomhu/.pyenv/versions/3.11.5/lib/python3.11/subprocess.py", line 1950, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'sentry-prevent-cli'

[thomasrockhu-codecov]

I guess are we assuming someone already has sentry-prevent-cli installed?

[spalmurray]

yes I guess it does assume that. It also assumes you have the codecov-cli installed. I'll add a check to the start of the script that checks for the executables and gives installation instructions otherwise.