fix: configurable rebranding#7
Merged
Merged
Conversation
Contributor
joseph-sentry
commented
May 2, 2025
joseph-sentry
commented
- accept unbranded --yml-path in the new cli
- add configurable rebranding for options expecting env vars
- make the branding configurable through the click context user data obj
- add the BrandedOption and CodecovBrandedOption classes for having env vars for the options follow the branding passed in the context
- also makes the codecov-cli source in the prevent-cli pyproject editable
❌ 10 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| authors = [ | ||
| { name = "joseph-sentry", email = "joseph.sawaya@sentry.io" } | ||
| ] | ||
| authors = [{ name = "joseph-sentry", email = "joseph.sawaya@sentry.io" }] |
Collaborator
There was a problem hiding this comment.
I'd probably add GitHub handle if it allows for that, but also, we may want to make this a team email too
spalmurray
reviewed
May 8, 2025
spalmurray
reviewed
May 8, 2025
| ctx.obj["codecov_yaml"] = load_cli_config(codecov_yml_path) | ||
| ctx.obj["codecov_yaml"] = load_cli_config(yml_path) | ||
| if ctx.obj["codecov_yaml"] is None: | ||
| logger.debug("No codecov_yaml found") |
Collaborator
There was a problem hiding this comment.
branding on the log ling here
spalmurray
reviewed
May 8, 2025
joseph-sentry
force-pushed
the
joseph/branding
branch
from
9d9c32c to
6be4859
Compare
- accept unbranded --yml-path in the new cli
- add configurable rebranding for options expecting env vars
- make the branding configurable through the click context user
data obj
- add the BrandedOption and CodecovBrandedOption classes for
having env vars for the options follow the branding passed in
the context
- also makes the codecov-cli source in the prevent-cli pyproject
editable
joseph-sentry
force-pushed
the
joseph/branding
branch
from
eb32194 to
bd42df1
Compare
spalmurray
reviewed
Jun 24, 2025
Collaborator
There was a problem hiding this comment.
wait so is it yml-path for preventcli and codecov-yml-path for codecovcli?
Collaborator
There was a problem hiding this comment.
JW why the commands list for codecovcli didn't change
spalmurray
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.