Resolved an issue with badly recorded crumbs.

Author: mitsuhiko

CHANGES

@@ -4,6 +4,7 @@ Version 5.19.0
 * remove duration from SQL query breadcrumbs. This was not rendered
   in the UI and will come back in future versions of Sentry with a
   different interface.
+* resolved a bug that caused crumbs to be recorded incorrectly.
 
 Version 5.18.0
 --------------

raven/breadcrumbs.py

@@ -92,8 +92,8 @@ def record(message=None, timestamp=None, level=None, category=None,
     if timestamp is None:
         timestamp = time.time()
     for ctx in raven.context.get_active_contexts():
-        ctx.breadcrumbs.record(type, timestamp, level, message,
-                               category, data, processor)
+        ctx.breadcrumbs.record(timestamp, level, message, category,
+                               data, type, processor)
 
 
 def _record_log_breadcrumb(logger, level, msg, *args, **kwargs):

tests/breadcrumbs/tests.py

@@ -4,7 +4,7 @@
 from raven.utils.testutils import TestCase
 
 from raven.base import Client
-from raven.breadcrumbs import record_breadcrumb
+from raven import breadcrumbs
 
 from io import StringIO
 
@@ -16,8 +16,8 @@ def test_crumb_buffer(self):
             client = Client('http://foo:bar@example.com/0',
                             enable_breadcrumbs=enable)
             with client.context:
-                record_breadcrumb('foo', data={'bar': 'baz'},
-                                  message='aha', category='huhu')
+                breadcrumbs.record(type='foo', data={'bar': 'baz'},
+                                   message='aha', category='huhu')
                 crumbs = client.context.breadcrumbs.get_buffer()
                 assert len(crumbs) == enable
 
@@ -92,3 +92,30 @@ def test_dedup_logging(self):
         assert crumbs[2]['type'] == 'default'
         assert crumbs[2]['category'] == 'whatever.foo'
         assert crumbs[2]['message'] == 'This is a message with 42!'
+
+    def test_manual_record(self):
+        client = Client('http://foo:bar@example.com/0')
+        with client.context:
+            def processor(data):
+                assert data['message'] == 'whatever'
+                assert data['level'] == 'warning'
+                assert data['category'] == 'category'
+                assert data['type'] == 'the_type'
+                assert data['data'] == {'foo': 'bar'}
+                data['data']['extra'] = 'something'
+
+            breadcrumbs.record(message='whatever',
+                               level='warning',
+                               category='category',
+                               data={'foo': 'bar'},
+                               type='the_type',
+                               processor=processor)
+
+            crumbs = client.context.breadcrumbs.get_buffer()
+            assert len(crumbs) == 1
+            data = crumbs[0]
+            assert data['message'] == 'whatever'
+            assert data['level'] == 'warning'
+            assert data['category'] == 'category'
+            assert data['type'] == 'the_type'
+            assert data['data'] == {'foo': 'bar', 'extra': 'something'}