ref(minidump): Use get instead of indexing#5974
Draft
elramen wants to merge 1 commit into
Draft
Conversation
jjbayer
reviewed
May 11, 2026
|
|
||
| let minidump_item = items | ||
| .get(minidump_idx) | ||
| .ok_or(BadStoreRequest::MissingMinidump)?; |
Member
There was a problem hiding this comment.
Shouldn't every ? in this function call .reject(&items)? You can change the return type of the function to Result<_, Rejected<_>> to force this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
getinstead of indexing to access the minidump item. Follow up for https://github.com/getsentry/relay/pull/5950/changes#r3207341577.