ref(upload): Explicitly reject items when an objectstore upload fails#5976
Merged
Conversation
jjbayer
commented
May 11, 2026
| upload: &Addr<Upload>, | ||
| referrer: &'static str, | ||
| ) -> Option<Managed<Item>> | ||
| ) -> Result<Managed<Item>, Rejected<()>> |
Member
Author
There was a problem hiding this comment.
Changing the signature of this function is not strictly necessary to do the rejection (i.e. the outcome reporting), but it makes the rejection more explicit to the caller.
| project_config["config"].setdefault("features", []).append( | ||
| "projects:relay-minidump-attachment-uploads" | ||
| ) | ||
| mini_sentry.global_config["options"]["relay.endpoint-fetch-config.enabled"] = True |
Member
There was a problem hiding this comment.
This should not be needed per se since we already enable it here:
but if you think it is better to also explicitly set it here it is fine with me.
tobias-wilfert
approved these changes
May 12, 2026
jjbayer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
upload_to_objectstorefails, reject items explicitly to make it more obvious which outcomes are emitted.