fix(attachments): Store the attachment file name in objectstore - #6276
Draft
jan-auer wants to merge 2 commits into
Draft
fix(attachments): Store the attachment file name in objectstore#6276jan-auer wants to merge 2 commits into
jan-auer wants to merge 2 commits into
Conversation
lcian
reviewed
Jul 31, 2026
| #[cfg(debug_assertions)] | ||
| let original_key = key.clone(); | ||
|
|
||
| let attributes = ObjectAttributes { |
Member
There was a problem hiding this comment.
Don't these have a filename we could use?
loewenheim
approved these changes
Jul 31, 2026
lcian
approved these changes
Jul 31, 2026
Member
Author
|
Put on hold. Permissible unicode characters in filenames are sent verbatim to objectstore server, where they will fail during metadata construction. This must be fixed on the server-side first (Filed as FS-467) |
jan-auer
marked this pull request as draft
July 31, 2026 10:54
Member
Author
|
Ready to merge after getsentry/objectstore#581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectstore only sends
Content-Dispositionfor objects that were stored withfilenamemetadata. Relay never set it, so after getsentry/sentry#120958 started redirecting attachment downloads to Objectstore, downloads were named after the storage key instead of the attachment.Bumps
objectstore-clientto 0.2.0, which addsPutBuilder::filename, and passes the attachment item's file name for both event attachments and standalone (individual) attachments. The name is forwarded verbatim; escaping for theContent-Dispositionheader is Objectstore's concern, not the caller's. Only newly stored objects are affected.Attachments uploaded through the chunked upload endpoint (
attachment_ref) still have no file name: the TUSUpload-Metadataheader carries one, but Relay only parses itssentrykey and the object is already stored by the time the envelope arrives. Left as follow-up.Refs FS-466
See getsentry/sentry#120958