fix(mapping): Parse Compose mappings with flexible indentation#93
Merged
fix(mapping): Parse Compose mappings with flexible indentation#93
Conversation
Accept indented member lines instead of requiring exactly four spaces so raw ComposeStackTrace -> 98418compose blocks parse correctly. Bump the proguard cache format version so existing caches built from truncated Compose mappings are recalculated with the fixed parser. Co-Authored-By: Codex <noreply@openai.com>
Dav1dde
reviewed
Apr 20, 2026
Member
|
Kotlin fix: JetBrains/kotlin#5898 |
Leave the cache format version alone in rust-proguard because the parser compatibility fix does not change the serialized cache layout. Cache invalidation for existing symbolicator caches will happen on the consumer side instead. Co-Authored-By: Codex <noreply@openai.com>
loewenheim
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse Compose mappings with flexible indentation
ComposeStackTrace -> $$compose:sections generated by recent Android builds use two-space member indentation. The Compose compiler emits those entries with two leading spaces in https://github.com/JetBrains/kotlin/blob/effb244358aec74b7fa752d70a1055b4ea2f3e57/plugins/compose/group-mapping/src/main/kotlin/androidx/compose/compiler/mapping/ComposeMapping.kt#L54, which does not follow the ProGuard spec for member lines. As a result, those entries were dropped during cache generation, leaving symbolication able to remap$$composetoComposeStackTracebut not to the original methods.I already filed https://issuetracker.google.com/issues/504284805, but we still need to fix this on our side because there are existing broken mappings in the wild that we need to support. This changes the parser to accept indented member lines and adds focused mapper and cache regressions for the raw Compose stacktrace shape.
Refs getsentry/sentry-android-gradle-plugin#1065