feat: set --max-poll-interval-ms flags to Sentry/Snuba consumers#4376
Conversation
Separated from #4313 Also introducint a healthcheck for snuba-replacer
| # The default value is 30000 ms (30 seconds). | ||
| # SENTRY_KAFKA_MAX_POLL_INTERVAL_MS=30000 |
There was a problem hiding this comment.
Bug: The documented default for SENTRY_KAFKA_MAX_POLL_INTERVAL_MS in .env is 30000, but the docker-compose.yml default is 300000.
Severity: LOW
Suggested Fix
Align the documented default value in the .env file with the actual default value used in docker-compose.yml. Change the comment in .env to reflect the 300000 ms default.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .env#L51-L52
Potential issue: There is a mismatch between the documented default value for
`SENTRY_KAFKA_MAX_POLL_INTERVAL_MS` and its implementation. The comment in the `.env`
file states the default is `30000` ms, but the `docker-compose.yml` services use a
default of `300000` ms. This 10x difference could mislead users who rely on the
documentation, potentially causing them to set a much shorter interval than intended,
which could lead to the Kafka rebalancing issues this setting is designed to mitigate.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 55c8540. Configure here.
|
Hi, I was reviewing the changes before upgrading our sentry setup and had the same thought as the clanker in #4376 (review) ; I was wondering why there is a fallback of 300_000 ms all over the place in the compose yaml, but the documentation says that the default is 30 seconds? |

Separated from #4313
Also introducint a healthcheck for snuba-replacer