Skip to content

Commit 05116b2

Browse files
runningcodeclaude
andauthored
fix(snapshots): Rename generateTests to generateSnapshotTests (#1148)
* fix(snapshots): Rename generateTests to generateSnapshotTests The property name `generateTests` is too generic within the snapshots extension. Rename to `generateSnapshotTests` for clarity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(snapshots): Fix spotless formatting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6a2af45 commit 05116b2

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ private fun ApplicationVariant.configureSnapshotsTasks(
488488

489489
// Wire Paparazzi test generation and upload task when the Paparazzi plugin is applied
490490
project.pluginManager.withPlugin("app.cash.paparazzi") {
491-
if (extension.snapshots.generateTests.get()) {
491+
if (extension.snapshots.generateSnapshotTests.get()) {
492492
val android = project.extensions.getByType(BaseExtension::class.java)
493493

494494
project.dependencies.add(

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtension.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ open class SnapshotsExtension @Inject constructor(objects: ObjectFactory) {
1111

1212
val enabled: Property<Boolean> = objects.property(Boolean::class.java).convention(false)
1313

14-
val generateTests: Property<Boolean> = objects.property(Boolean::class.java).convention(true)
14+
val generateSnapshotTests: Property<Boolean> =
15+
objects.property(Boolean::class.java).convention(true)
1516

1617
val includePrivatePreviews: Property<Boolean> =
1718
objects.property(Boolean::class.java).convention(true)

plugin-build/src/test/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtensionTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,21 @@ class SnapshotsExtensionTest {
1616
}
1717

1818
@Test
19-
fun `generateTests is true by default`() {
19+
fun `generateSnapshotTests is true by default`() {
2020
val project = ProjectBuilder.builder().build()
2121
val extension = project.objects.newInstance(SnapshotsExtension::class.java)
2222

23-
assertTrue(extension.generateTests.get())
23+
assertTrue(extension.generateSnapshotTests.get())
2424
}
2525

2626
@Test
27-
fun `generateTests can be set to false`() {
27+
fun `generateSnapshotTests can be set to false`() {
2828
val project = ProjectBuilder.builder().build()
2929
val extension = project.objects.newInstance(SnapshotsExtension::class.java)
3030

31-
extension.generateTests.set(false)
31+
extension.generateSnapshotTests.set(false)
3232

33-
assertFalse(extension.generateTests.get())
33+
assertFalse(extension.generateSnapshotTests.get())
3434
}
3535

3636
@Test

0 commit comments

Comments
 (0)